Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagemagick: update and support for additional image formats and fonts #5414

Merged
merged 14 commits into from
Nov 22, 2022

Conversation

hgy59
Copy link
Contributor

@hgy59 hgy59 commented Sep 5, 2022

Description

  • update imagemagick to v7.1.0-47
  • add DejaVu fonts
  • update OpenJPEG
  • add LibRaw
  • add OpenEXR
  • add librsvg
  • add libraqm
  • add djvulibre

Includes several build optimizations like

  • disable build of unused static libraries
  • create optimized code

Fixes #3881

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@hgy59

This comment was marked as outdated.

@th0ma7
Copy link
Contributor

th0ma7 commented Nov 15, 2022

This is odd, let me have a look at it over the weekend, i might find a fix for it.

@th0ma7
Copy link
Contributor

th0ma7 commented Nov 16, 2022

While comuting back home I thought of a few things... first off, I don't recall CARGO_HOME_PATH but rather only CARGO_HOME variable. You could try the following:

  1. Change the PATH order for cargo in spksrc.common.mk to:
# Add cargo for rust compiler to default PATH
export PATH := $(PATH):/opt/cargo/bin
  1. Or, something really ugly such as the following to remove cargo entirely from the PATH, adding something close to this to ImageMagick Makefile:
PATH := $(subst  ,:,$(patsubst %cargo%,,$(subst :, ,$(PATH))))

🤷‍♂️

@hgy59
Copy link
Contributor Author

hgy59 commented Nov 16, 2022

@th0ma7 sorry to bother you, it had nothing to do with the PATH. With the new image there is no CARGO/RUST folder in the path.

@hgy59 hgy59 mentioned this pull request Nov 16, 2022
6 tasks
@th0ma7
Copy link
Contributor

th0ma7 commented Nov 16, 2022

Have you found how to fix it?

- update lcms2
- enable code optimization
- disable static library to speedup the build
- add cross/librsvg
- add cross/libcroco
- add cross/gdk-pixbuff
- update imagemagick to v7.1.0-47
- add DejaVu fonts
- update OpenJPEG
- add LibRaw
- add OpenEXR
- add librsvg
- optimizations
- sickchill needs update as 2021.* sources are gone
- patch library runpath in some bin and lib files
- fix rsvg integration (magick depends on bin/rsvg-convert)
- zlib.pc fix fixes OpenEXR integration
@th0ma7
Copy link
Contributor

th0ma7 commented Nov 21, 2022

If you create a harbuzz_v3 for armv7l the i could reuse that for ffmpeg related to libass that now gets removed from that build.

@hgy59 hgy59 merged commit 7f889b7 into SynoCommunity:master Nov 22, 2022
@hgy59 hgy59 deleted the update_imagemagick branch November 22, 2022 06:01
hgy59 added a commit to hgy59/spksrc that referenced this pull request Dec 2, 2022
- sickchill was declared as broken with SynoCommunity#5414, but meanwhile fixed in SynoCommunity#5458
@hgy59 hgy59 mentioned this pull request Dec 2, 2022
hgy59 added a commit that referenced this pull request Dec 2, 2022
- sickchill was declared as broken with #5414, but meanwhile fixed in #5458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageMagick not converting SVG to Bitmap
2 participants