Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SickChill 20221013 - 5449 revival #5458

Merged
merged 18 commits into from
Oct 22, 2022
Merged

SickChill 20221013 - 5449 revival #5458

merged 18 commits into from
Oct 22, 2022

Conversation

BKSteve
Copy link
Contributor

@BKSteve BKSteve commented Oct 19, 2022 •
edited
Loading

SickChill redo

Fixes #5449

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@BKSteve BKSteve mentioned this pull request Oct 19, 2022
Merged
16 tasks
@BKSteve
Copy link
Contributor Author

BKSteve commented Oct 21, 2022

removal of @appstore/sickchill working on both 6&7
upgrading works on both 6&7

@BKSteve
Copy link
Contributor Author

BKSteve commented Oct 22, 2022

@th0ma7 this shows to have fixed user name and update issues of #5449.
Please review.

@th0ma7 th0ma7 merged commit 30479f6 into SynoCommunity:master Oct 22, 2022
@th0ma7
Copy link
Contributor

th0ma7 commented Oct 22, 2022

LGTM, now merged

@th0ma7 th0ma7 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Oct 23, 2022
@th0ma7
Copy link
Contributor

th0ma7 commented Oct 23, 2022

And now published. Again thnx a lot for your contribution! Cheers!

@BKSteve
Copy link
Contributor Author

BKSteve commented Oct 23, 2022

Wouldn't have been possible without all the cryptography rust work

@th0ma7
Copy link
Contributor

th0ma7 commented Oct 24, 2022

Thnx for mentioning but I'm not the only player here as I started off from where @hgy59 had already came with. Again, thnx for your contribution.

@hgy59 hgy59 mentioned this pull request Dec 2, 2022
Closed
1 task
hgy59 added a commit to hgy59/spksrc that referenced this pull request Dec 2, 2022
@hgy59
sickchill: remove BROKEN
d861349 
- sickchill was declared as broken with SynoCommunity#5414, but meanwhile fixed in SynoCommunity#5458
@hgy59 hgy59 mentioned this pull request Dec 2, 2022
Merged
hgy59 added a commit that referenced this pull request Dec 2, 2022
@hgy59
sickchill: remove BROKEN (#5510)
44a3d5d 
- sickchill was declared as broken with #5414, but meanwhile fixed in #5458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th0ma7 th0ma7 th0ma7 approved these changes

Assignees
No one assigned
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BKSteve @th0ma7