mono: update to v6.12.0.182 #5677

hgy59 · 2023-03-26T18:20:41Z

Description

update mono
fix BTLS library for aarch64 built with gcc 4 (Mono 5.18 SSL store problems on aarch64 platforms #3666)
remove some features to keep the package as small as possible
- remove profiling feature
- remove boehm gc
- remove ikvm library
disable packages for ARMv5 by removing ARMv5 from UNSUPPORTED_ARCHS
it is still possible to create such a package, but without a TLS library most use cases will not work
add a script to update mono ca certificates after installation

Fixes #3666, closes #4054, closes #4669

Checklist

Build rule all-supported completed successfully
New installation of package completed successfully
Package upgrade completed successfully (Manually install the package again)
Package functionality was tested
Any needed documentation is updated/created

Type of change

Bug fix
Package update

hgy59 · 2023-03-26T19:57:51Z

@mreid-tt finally I got all issues with Mono package fixed.

Additional information for the package is available in our wiki https://github.com/SynoCommunity/spksrc/wiki/FAQ-Mono

mreid-tt · 2023-03-26T20:34:45Z

@hgy59, I started with an upgrade from the current version to this one on DSM 6. Unfortunately I got what seems to be a failed update and Sonarr v3 is also unable to start with this version. Logs below:

/var/log/packages/mono.log - https://pastebin.com/X2QJDNwQ
/var/log/packages/nzbdrone.log - https://pastebin.com/nz7iwc2s
/var/packages/nzbdrone/var/nzbdrone.log - https://pastebin.com/Dh66zMfR

hgy59 · 2023-03-26T21:10:51Z

@mreid-tt thanks for the feedback. I didn't expect that a package requires the AOT compiler... fixing this.

mreid-tt · 2023-03-26T22:22:14Z

@mreid-tt thanks for the feedback. I didn't expect that a package requires the AOT compiler... fixing this.

@hgy59, that seems to have done it! Upgrades on DSM 6 and DSM 7 were both successful:

/var/log/packages/mono.log (DSM 6) - https://pastebin.com/3Q4jLXri
/var/log/packages/mono.log (DSM 7) - https://pastebin.com/SuE5VHBQ

EDIT: I don't know why the logs show two different behaviours regarding stored certificates. Is it the DSM version? If so, any idea why the number of certificates are different?

hgy59 · 2023-03-26T22:40:56Z

EDIT: I don't know why the logs show two different behaviours regarding stored certificates. Is it the DSM version? If so, any idea why the number of certificates are different?

The laziness of synology...

I have two different models with DSM 7.1.1-42962 Update 4
both have a ca-certificates.crt file of 29.12.2021 with 3374 lines

another model with DSM 6.2.4-25556 Update 6 has one of 01.05.2021 with 3823 lines

mreid-tt · 2023-03-26T22:47:16Z

Thanks for the feedback. All seems okay then. I only tested this on my x64 platform however and don't have the hardware to comment on aarch64 SSL store problems (#3666). Perhaps someone else can help test this?

spk/mono/src/update_ca_certificates.sh

hgy59 · 2023-03-26T23:07:12Z

Thanks for the feedback. All seems okay then. I only tested this on my x64 platform however and don't have the hardware to comment on aarch64 SSL store problems (#3666). Perhaps someone else can help test this?

I have a DS218 to test this (and it worked)
But currently is fails again (for all archs I have testsed). Have to investigate into (but will be offline for about a week).

To test I use a simple csharp program webclient.ch:

using System;
using System.Net;
using System.IO;

public class WebClientTest
{
    public static void Main(string[] args)
    {
        if (args == null || args.Length == 0)
        {
            throw new ApplicationException("Specify the URI of the resource to retrieve.");
        }
        using (WebClient client = new WebClient())
        {
            // Add a user agent header in case the
            // requested URI contains a query.
            client.Headers.Add("user-agent", "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.2; .NET CLR 1.0.3705;)");

            using (Stream data = client.OpenRead(args[0]))
            using (StreamReader reader = new StreamReader(data))
            {
                string s = reader.ReadToEnd();
                Console.WriteLine(s);
            }
        }
    }
}

simply compile this with

mcs webclient.cs

And run with any https site like:

mono webclient.exe https://google.com

But as I mentioned above this currently fails

on aarch64 with elliptic curve routines:OPENSSL_internal:POINT_IS_NOT_ON_CURVE
on other models with SSL routines:OPENSSL_internal:CERTIFICATE_VERIFY_FAILED

- update mono - fix BTLS library for aarch64 built with gcc 4 (SynoCommunity#3666) - remove some features to keep the package as small as possible - remove aot, profiling and debugging - remove boehm gc - remove ikvm library - disable packages for ARMv5 by removing ARMv5 from UNSUPPORTED_ARCHS it is still possible to create such a package, but without a TLS library most use cases will not work - add a script to update mono ca certificates after installation

- enforce build of BTLS library for ARMv5 archs - fixes mono/mono#11422

hgy59 · 2023-03-30T19:59:20Z

@mreid-tt this works now on DS218 (aarch64) with DSM 6.1

hgy59 · 2023-03-30T20:01:30Z

.github/actions/prepare.sh

+    # If packages contain a package that depends on ffmpeg (or is ffmpeg), then ensure
+    # relevant ffmpeg4|ffmpeg5|ffmpeg6 is first in list
+    for package in ${packages}
+    do
+        if [ "$(echo ffmpeg${i} ${ffmpeg_dependent_packages} | grep -ow ${package})" != "" ]; then
+            packages_without_ffmpeg=$(echo "${packages}" | tr ' ' '\n' | grep -v "ffmpeg${i}" | tr '\n' ' ')
+            packages="ffmpeg${i} ${packages_without_ffmpeg}"
+            break
+        fi
+    done


@th0ma7 this fix avoids the build of ffmpeg4 for unrelated changes.

Excellent, once merged i'll create a dymmy pr to rouble check it does work when needed.

@th0ma7 I already checked by touching tvh (see evaluate dependencies in: https://github.com/SynoCommunity/spksrc/actions/runs/4567381299/jobs/8061093361)
You find three aborted builds for this PR
Build # 5183 has debug output that shows the reason for triggering ffmpeg4
>>> ffmpeg_dependent_packages: version 4 : chromaprint comskip tvheadend

Awesome, thnx for fixing that.

mreid-tt · 2023-03-30T20:38:21Z

@mreid-tt this works now on DS218 (aarch64) with DSM 6.1

Excellent news! I've also re-tested a clean upgrade from mono v5 on both DSM 6 and DSM 7. The tests with Sonarr v3 were all successful.

* mono: update to v6.12.0.182 - update mono - fix BTLS library for aarch64 built with gcc 4 (SynoCommunity#3666) - remove some features to keep the package as small as possible - remove boehm gc - remove ikvm library - add a script to update mono ca certificates after installation * fix build for ARMv5 - enforce build of BTLS library for ARMv5 archs - fixes mono/mono#11422 * fix ffmpeg dependency evaluation in prepare build

hgy59 mentioned this pull request Mar 26, 2023

Mono 6.12 for DSM 7.0 #4669

Closed

3 tasks

hgy59 requested a review from mreid-tt March 26, 2023 19:55

mreid-tt reviewed Mar 26, 2023

View reviewed changes

spk/mono/src/update_ca_certificates.sh Show resolved Hide resolved

hgy59 added the status/work-in-progress label Mar 26, 2023

hgy59 mentioned this pull request Mar 30, 2023

ffmpeg5 + ffmpeg6 packages #5620

Merged

10 tasks

hgy59 added 4 commits March 30, 2023 19:10

fix build for ARMv5

601c14b

- enforce build of BTLS library for ARMv5 archs - fixes mono/mono#11422

keep aot and debugging features

0e6032f

fix arch specific configuration

e225180

hgy59 force-pushed the update_mono branch 2 times, most recently from ec98b62 to 69a792f Compare March 30, 2023 17:39

fix ffmpeg dependency evaluation in prepare build

17f835f

hgy59 force-pushed the update_mono branch from ddfa91e to 17f835f Compare March 30, 2023 17:54

hgy59 removed the status/work-in-progress label Mar 30, 2023

hgy59 commented Mar 30, 2023

View reviewed changes

mreid-tt approved these changes Mar 30, 2023

View reviewed changes

hgy59 merged commit a578b4b into SynoCommunity:master Mar 30, 2023

hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Mar 31, 2023

hgy59 deleted the update_mono branch March 31, 2023 20:09

mreid-tt mentioned this pull request Apr 1, 2023

Sonarr unable to connect to indexer after Mono upgrade to 5.20.1.34 #4206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mono: update to v6.12.0.182 #5677

mono: update to v6.12.0.182 #5677

hgy59 commented Mar 26, 2023 •

edited

Loading

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023 •

edited

Loading

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023

hgy59 commented Mar 26, 2023

hgy59 commented Mar 30, 2023

hgy59 Mar 30, 2023

th0ma7 Mar 30, 2023

hgy59 Mar 30, 2023

th0ma7 Mar 31, 2023

mreid-tt commented Mar 30, 2023

mono: update to v6.12.0.182 #5677

mono: update to v6.12.0.182 #5677

Conversation

hgy59 commented Mar 26, 2023 • edited Loading

Description

Checklist

Type of change

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023 • edited Loading

hgy59 commented Mar 26, 2023

mreid-tt commented Mar 26, 2023

hgy59 commented Mar 26, 2023

hgy59 commented Mar 30, 2023

hgy59 Mar 30, 2023

Choose a reason for hiding this comment

th0ma7 Mar 30, 2023

Choose a reason for hiding this comment

hgy59 Mar 30, 2023

Choose a reason for hiding this comment

th0ma7 Mar 31, 2023

Choose a reason for hiding this comment

mreid-tt commented Mar 30, 2023

hgy59 commented Mar 26, 2023 •

edited

Loading

mreid-tt commented Mar 26, 2023 •

edited

Loading