-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10.12 and 3.11.4 update #5800
Conversation
@hgy59 this will require a second pair of eye... Overall this PR is relatively trivial besides:
The real hit here is |
@hgy59 friendly reminder that your thoughts on |
Recently I tried to build mosquitto with openssl3 as the dependencies are cross/libwebsockets and cross/cjson only and do not touch other packages. |
@hgy59 look at my commits, i did solved that by disabling asm on that specific arch and version |
There is a patch for aarch64 with older compilers, it is for 6.1 only and must be applied for 6.2.4 too. No need to disable asm. |
@hgy59 I just saw your PR. Let me rebase against master and undo that change related to asm. Otherwise, are you ok with initiating openssl3 migration starting with this pr? |
This fix python/cpython#103282 actually breaks things using GCC 4.6.4 when enforcing c99.
@th0ma7 I have started a build (one arch only) of all packages with all cross/openssl references updated to cross/openssl3. |
@hgy59 ok, let me know what comes out of it. On my end I have succesfully tested python builds on x86_64 + deluge #5801 and all looks good AFAIK. And indeed github action won't be of any help... But let me know if you intend to merge something to master and need to rebase against it and revert what may be superseeded by your PR if any. |
@hgy59 interestingly armv5 github-action was able to fully complete with no errors which gives a nice idea of the situation. |
So, now what? :) |
my openssl build tests didn't find large show stoppers. One is the erlang/rabbitmq/ejabberd set of packages (that I already started to migrate with #5813 and #5814. I think you can go forward with python and openssl3 Just found out that openssl 3.1.1 is not an LTS version and will expire on 14th March 2025 I would continue with 3.1.1 if you don't mind. |
Will do.
I tend to agree with that as well. |
@th0ma7, is this published already? |
@mreid-tt yup, done yesterday |
@th0ma7, @hgy59 It looks like this is related to the change in OpenSSL version. Could you kindly check it please. My system: MARVELL Armada 385 88F6820, DSM 6.2.4-25556 Update 7
|
This really is somothing obvious I should have cought in my testing 😞 @hogi1200 can you test out resulting package from PR #5818 and see if this fixes your issue? @mreid-tt I've disabled the packages online in the meantime to avoid receving too many of theses issues all over the place. @hgy59 I'll test things further with my proposed change and see if this fixes things. Otherwise I'll revert the |
@hogi1200 my initiatial testing shows that my proposed fix does solves things. I suggest you install the resulting package corresponding to your NAS arch from the github-action build here (once completed) https://github.com/SynoCommunity/spksrc/actions/runs/5630487543 to confirm issue is confirmed to be solved for you. |
@hogi1200 updated python packages should now be available online for you to download and install manuall or pending next update within your package center. Please let it know it issue is still hapening. |
@th0ma7 |
Description
Python 3.10.12 and 3.11.4 update
Fixes n/a
Checklist
all-supported
completed successfullyType of change