-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove dash from model ID while exporting to SMBL format #167
Conversation
dash causes problems when exporting to SBML
Nice fix! Would it make sense to also rename the |
@mihai-sysbio Yes, it would probably be a good idea to change the model filenames as well to be consistent. We just need to make sure that the names of all other model versions ( |
yes, we could add a project "Aligning model filenames with ID of repo and model" to coordinate efforts toward this goal, probably through multiple commits/PRs. |
@Hao-Chalmers I think creating an issue is sufficient, it's not a big enough change to be considered a "project." |
The dash in the model ID
Human-GEM
causes problems with SBML I/O, so this fix removes the dash (HumanGEM
) in only the SBML file. The model ID will remain asHuman-GEM
everywhere else.I hereby confirm that I have:
devel
as a target branch