Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human 1.12 #396

Merged
merged 59 commits into from
Jun 21, 2022
Merged

Human 1.12 #396

merged 59 commits into from
Jun 21, 2022

Conversation

mihai-sysbio
Copy link
Member

@mihai-sysbio mihai-sysbio commented Jun 17, 2022

Main improvements in this PR:

ANiknejad and others added 30 commits January 21, 2022 12:22
…60 (instead of previous erroneous MAM01656 dehydrodolichol)
…to CHEBI:28542 (2-deoxy-D-ribofuranose 1-phosphate)
* added metabolites MAM01639n and MAM01686n
* changed MAR07160 and MAR07163
* added MAR13084 and MAR13085
- add RNA in nucleus
- add reaction MAR13086, transport of RNA from nucleus to cytoplasm
- add compartmentalised metabolite RNA[n] (MAM02847n)
- change reaction MAR07161 (RNA creation) from cytoplasm to nucleus
- add transport reaction of RNA from the nucleus to cytoplasm (MAR13086)
- move gene rule of reaction MAR08639 to reaction MAR13086, as it represents the nuclear pore complex
- swap the direction of reaction MAR07162, as explained in issue #354
- remove the reaction of DNA transport between the nucleus and cytoplasm MAR08639, since DNA shouldn't go out of the nucleus and the reaction's gene rule is no longer needed
- delete reaction MAR08639 and add reaction MAR13086
- add deleted reaction MAR08639 to deprecatedReactions.tsv
- score of reaction MAR13086 changed to 2
MAM01614 corticosterone, remapped to CHEBI:16827
MAM01631 remapped to CHEBI:83739
doing modifications on the file as asked by Jonathan in

#358 (comment)
#358 (comment)
#358 (comment)
(re) example of correction to apply in order to avoid conflict during MNXref conversion
…nto-MAR04474

refactor: merge MAR08973 into MAR04474
doc: tINIT rename 'exchange metabolites' to 'boundary metabolites'
Fix: flag reactions MAR05127, MAR08749, MAR08750 as spontaneous
johan-gson and others added 21 commits May 13, 2022 10:14
…ed legacy. This makes the pull requests in RAVEN and Human-GEM independent. Let's fix this at some later point.
- the previous way relies on specific reaction feature, which may not exist in some models. Now subsystem and equation can be properly loaded regardless of the presence of certain slots reaction features
refactor: turn `importYaml` into a more generic function
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, reformatted the PR messages a bit

Copy link
Collaborator

@JonathanRob JonathanRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the merge conflict has something to do with the date in the Human-GEM.yml file, maybe?

@haowang-bioinfo
Copy link
Member

I assume the merge conflict has something to do with the date in the Human-GEM.yml file, maybe?

The merge from develop into main is detailed in the wiki

@JonathanRob
Copy link
Collaborator

Ok, thanks, @haowang-bioinfo. It's weird, I was trying to view the new release instructions on the wiki recently and it wasn't loading properly, but now it seems to work.

@haowang-bioinfo haowang-bioinfo marked this pull request as ready for review June 21, 2022 00:02
@haowang-bioinfo
Copy link
Member

will just merge this and move things forward

@haowang-bioinfo haowang-bioinfo merged commit d9acb65 into main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants