Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refine GPRs in Pentose phosphate pathway #515

Merged
merged 4 commits into from
Mar 28, 2023

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

This PR improves GPRs in Pentose phosphate pathway, as proposed in #501

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The changes are made according to the description.

@@ -70773,8 +70773,8 @@
- MAM01672c: -1
- MAM02039c: 1
- lower_bound: 0
- upper_bound: 1000
- gene_reaction_rule: "ENSG00000158019 or ENSG00000171174"
- upper_bound: 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention the bound change in the commit?

Copy link
Member Author

@haowang-bioinfo haowang-bioinfo Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spot! resumed upper bound in 699893a and added gene ENSG00000171174 back in be86919

@haowang-bioinfo haowang-bioinfo merged commit 0d82fe6 into develop Mar 28, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/refineGPRs4PPP branch March 28, 2023 15:33
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants