Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse 1.1 #7

Merged
merged 8 commits into from
Jan 15, 2021
Merged

Mouse 1.1 #7

merged 8 commits into from
Jan 15, 2021

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Jan 14, 2021

Main improvements in this PR:

@mihai-sysbio
Copy link
Member

mihai-sysbio commented Jan 14, 2021

With the versioning in Human-GEM and Mouse-GEM being different, I'm wondering how to make it more obvious to the community what version of the Human-GEM is used. Perhaps the version could be added to the Readme in the line with "Model source".

@@ -9,3 +9,4 @@ rxns equations ub lb eccodes subSystems grRules rxnReferences rxnConfidenceScore
"MA_20008" "O2[r] + L-gulono-1,4-lactone[r] => H2O2[r] + ascorbate[r] + H+[r]" 1000 0 "1.1.3.8" "Ascorbate and aldarate metabolism" "Gulo" "PMID:14962674" 4 "R10053" "RXN-13689" "" "MNXR116004"
"MA_20009" "O2[r] + L-gulono-1,4-lactone[r] => H2O2[r] + L-xylo-Hexulonolactone[r]" 1000 0 "1.1.3.8" "Ascorbate and aldarate metabolism" "Gulo" "" 2 "R03184" "L-GULONOLACTONE-OXIDASE-RXN" "" "MNXR140097"
"MA_20010" "PAPS[c] + aniline[c] => PAP[c] + Benzenamine sulfate[c] + H+[c]" 1000 0 "2.8.2.3" "Amine sulfotransferase" "Sult3a1" "" 2 "R01861" "" "" "MNXR107208"
"MA_20016" "ascorbate[r] => ascorbate[c]" 1000 0 "" "Transport" "" "" 0 "" "" "" ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see this transport reaction as being species-specific. However, it doesn't have any other external identifiers, and no literature reference. Perhaps then it is the result of gap-filling? And if so, shouldn't this reaction be part of Human-GEM - ie, is it really species specific?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this addition can be viewed as a result of gap-filling for achieving the metabolic task #257 (Biosynthesis of Vitamin C) defined in metabolicTasks_Full.xlsx. And it's not part of Human-GEM, since it's species-specific.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this reaction should be reversible, but I realize that's something that should probably be addressed in Human-GEM where it originates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This transportation from ER to cytosol is added for modelling purpose. If there is any reference reporting this transporter and indicating the reversibility? @JonathanRob

Copy link
Collaborator

@JonathanRob JonathanRob Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I didn't realize that these were mouse-specific reactions, not those coming from Human-GEM (even with the painfully obvious file name mouseSpecificRxns.tsv...). I don't know of any specific references, but this paper is probably a good place to start. For now though I think it's fine to keep the gap-filled reaction as you have it.

@haowang-bioinfo
Copy link
Member Author

Good question. The version dependency information is stored in the dependencies.txt file under model folder.

@mihai-sysbio
Copy link
Member

Good question. The version dependency information is stored in the dependencies.txt file under model folder.

It looks like that file duplicates some of the dependencies listed in the Readme. According to the DRY principle, I find it better to have only one place to store this. And for ease of access, the Readme looks like a better place. But perhaps that dependencies.txt file is managed programatically?

@haowang-bioinfo
Copy link
Member Author

It looks like that file duplicates some of the dependencies listed in the Readme. According to the DRY principle, I find it better to have only one place to store this. And for ease of access, the Readme looks like a better place. But perhaps that dependencies.txt file is managed programatically?

The dependencies.txt is the only place for version information. Yes, this file should be updated programatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants