Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rat 1.4 #11

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Rat 1.4 #11

merged 4 commits into from
Mar 10, 2023

Conversation

haowang-bioinfo
Copy link
Member

Main improvements in this PR:

  • Fixes (PR 460):
    • fix: correct MAM03882 annotation, as reported in Mouse-GEM #21
  • Fixes (PR 429):
    • feat: add Acod1(Irg1) gene and associated reaction, as discussed in Mouse-GEM #20
  • Features (commit f5f7845):
    • feat: update ortholog pairs from Alliance of Genomes to ver 5.3.0
  • Style (commit cee1e29):
    • change human-rat ortholog file from json to tsv, as discussed in Mouse-GEM #15

- Add code downloading orthologs from Alliance of Genomes Resources via cURL + jq
- Ortholog data synced from Alliance of Genomes Resources v5.3.0
@mihai-sysbio
Copy link
Member

It would be great to note somewhere which version of Human-GEM this is based on, perhaps in the README.

@haowang-bioinfo
Copy link
Member Author

It would be great to note somewhere which version of Human-GEM this is based on, perhaps in the README.

I believe you've asked this question before, would be good fix this somehow

@mihai-sysbio
Copy link
Member

I believe you've asked this question before, would be good fix this somehow

Indeed I have - but I still can't find where the Human-GEM dependency is listed. I'm asking about this since I know there have been quite a few releases improving Human-GEM since the previous release of Rat-GEM.

@haowang-bioinfo
Copy link
Member Author

I still can't find where the Human-GEM dependency is listed

the quick answer is the dependency file is in main branch only

@haowang-bioinfo
Copy link
Member Author

probably we should replace this step with an automatic approach via a centralized script in HumanGEM

@haowang-bioinfo haowang-bioinfo merged commit 5879c45 into main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants