Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad hoc task fail if with error "must be of the type int, null returned" #84

Closed
dmitriim opened this issue Sep 18, 2023 · 1 comment · Fixed by #91
Closed

Ad hoc task fail if with error "must be of the type int, null returned" #84

dmitriim opened this issue Sep 18, 2023 · 1 comment · Fixed by #91

Comments

@dmitriim
Copy link

In some cases duplicate_cm_to_course can return null, but function declares it will return int. That blows up ad hoc task it falis.

b9e118f95c2f:886 2023-09-16 22:14:23 Adhoc task failed: block_massaction\task\duplicate_task,Return value of block_massaction\massactionutils::duplicate_cm_to_course() must be of the type int, null returned
b9e118f95c2f:886 2023-09-16 22:14:23 Backtrace:
b9e118f95c2f:886 2023-09-16 22:14:23 * line 266 of /blocks/massaction/classes/actions.php: call to block_massaction\massactionutils::duplicate_cm_to_course()
b9e118f95c2f:886 2023-09-16 22:14:23 * line 61 of /blocks/massaction/classes/task/duplicate_task.php: call to block_massaction\actions::duplicate_to_course()
b9e118f95c2f:886 2023-09-16 22:14:23 * line 413 of /lib/cronlib.php: call to block_massaction\task\duplicate_task->execute()
b9e118f95c2f:886 2023-09-16 22:14:23 * line 206 of /lib/cronlib.php: call to cron_run_inner_adhoc_task()
b9e118f95c2f:886 2023-09-16 22:14:23 * line 175 of /admin/cli/adhoc_task.php: call to cron_run_adhoc_tasks()
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 16, 2023
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 16, 2023
@TomoTsuyuki
Copy link

I made PR #91 for this issue.
Please review and merge if it's ok.

TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 24, 2023
@Syxton Syxton linked a pull request Oct 25, 2023 that will close this issue
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 25, 2023
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Nov 21, 2023
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Nov 21, 2023
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Jan 11, 2024
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Jan 11, 2024
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants