Issue #84 Throw exception for the empty new cmid #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomoTsuyuki
force-pushed
the
issue84-for-401
branch
from
9272fbc
to
7406368
Compare
TomoTsuyuki
force-pushed
the
issue84-for-401
branch
from
7406368
to
4cb475a
Compare
|
@TomoTsuyuki I'm going to push these through, however I am also going to open an issue that new lang strings need to be added for these exceptions and log descriptions that have been added. Baked in English strings isn't the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #84
Cherry pick from #91