Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display block's content if a user doesn't have block/massaction:use #87

Closed
dmitriim opened this issue Sep 22, 2023 · 2 comments
Closed

Do not display block's content if a user doesn't have block/massaction:use #87

dmitriim opened this issue Sep 22, 2023 · 2 comments

Comments

@dmitriim
Copy link

There is a capability block/massaction:use that let users to use the block, however it's only checked in one spot https://github.com/Syxton/moodle-block_massaction/blob/master/action.php#L42

Would be much better UX if we check this capability before even rendering content so users without require permissions don't event see block.
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 19, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
e2ebf0b 
…sion
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 19, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
9cd924e 
…sion
@TomoTsuyuki
Copy link

I made PR #93 for this issue.
Please review and merge if it's ok.

TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 25, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
3ac512a 
…sion
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Oct 25, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
d575f36 
…sion
@TomoTsuyuki TomoTsuyuki mentioned this issue Oct 25, 2023
Merged
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Nov 21, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
7e126bb 
…sion
TomoTsuyuki added a commit to TomoTsuyuki/moodle-block_massaction that referenced this issue Nov 21, 2023
@TomoTsuyuki
Issue Syxton#87 Do not display content if a user does not have permis…
c69c542 
…sion
Syxton pushed a commit that referenced this issue Jan 8, 2024
@TomoTsuyuki
Issue #87 Do not display content if a user does not have permission (#93
003273a 
)
Syxton pushed a commit that referenced this issue Jan 8, 2024
@TomoTsuyuki
Issue #87 Do not display content if a user does not have permission (#…
652ccb6 
…100)
@Syxton
Copy link
Owner

Syxton commented Jan 10, 2024

merged in both branches. Thank you for your work on this!

@Syxton Syxton closed this as completed Jan 10, 2024
Syxton pushed a commit that referenced this issue Dec 16, 2024
@TomoTsuyuki @Syxton
Issue #87 Do not display content if a user does not have permission (#93
79d8289 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Syxton @dmitriim @TomoTsuyuki