Issue #87 Do not display content if a user does not have permission #93
Conversation
TomoTsuyuki
force-pushed
the
issue87-hide-block-by-capability
branch
from
e2ebf0b to
9cd924e
Compare
| $blockcontext = context_block::instance($this->instance->id); | ||
| if (!has_capability('block/massaction:use', $blockcontext)) { | ||
| $this->content->text = get_string('nopermissions', 'error', get_string('massaction:use', 'block_massaction')); | ||
| return $this->content; |
There was a problem hiding this comment.
Wondering why we need to display anything at all? IMHO we don't need to display content at all if user don't have permissions. But let's leave it up to the maintainer to decide.
There was a problem hiding this comment.
If a user adds the block without use permission, I think we need to show something for the block.
It's probably better not to allow to add the block if user doesn't have use permission.
I'm leaving this as I updated.
Please let me know which solution is better.
There was a problem hiding this comment.
Block can be already in a course when a user with caps to see the block, but without caps to do anything with mass actions accessing a course.
There was a problem hiding this comment.
I think the best method is to show the "No permission" message. I could see it being confusing if a user added the block but didn't see the block. They would probably think that the block wasn't added correctly. For as rare as this case would probably be I think I can live with it.
TomoTsuyuki
force-pushed
the
issue87-hide-block-by-capability
branch
from
9cd924e to
3ac512a
Compare
|
Rebased with the latest |
TomoTsuyuki
force-pushed
the
issue87-hide-block-by-capability
branch
from
3ac512a to
7e126bb
Compare
Show permission error if the user doesn't have permission.