Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port behat changes to 4.0 #22

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Port behat changes to 4.0 #22

merged 1 commit into from
Apr 18, 2022

Conversation

PhMemmel
Copy link
Collaborator

This PR cherrypicks the behat refactoring part of f9c525c and adds it to the master (4.0 compatible) branch.

Compatibility for flexsections and grid format is being left out as there both of these plugins do not seem to be compatible with moodle 4.0 yet.

@PhMemmel PhMemmel requested a review from Syxton April 16, 2022 07:37
@Syxton Syxton merged commit 4d2f89f into master Apr 18, 2022
@Syxton
Copy link
Owner

Syxton commented Apr 18, 2022

@PhMemmel I am running behat tests with all the 3rd party formats we have every accepted (flexsections, tiles, grid, topcoll, onetopic). It is a mess right now. I will make sure I have the latest of each and try again tomorrow.

@PhMemmel
Copy link
Collaborator Author

PhMemmel commented Apr 18, 2022

Thank you. Will at some point hopefully get my behat setup working. No idea what causes trouble there...

Should we consider splitting up the behat tests so we have a separate file for each course format?

@Syxton
Copy link
Owner

Syxton commented Apr 19, 2022

@PhMemmel I am getting ready to push a split up set of behat tests. Here are my current testing results for all course formats we have been dealing with. With core formats not using indent, I have moved the indent tests to each format set.

core passes all tests pass (1 skip is expected to test the "format is not installed" test)
topcoll latest passes all tests and should be supported.
grid needs updated to remove deprecated functions and implement indent, but our tests for it are probably correct. With all warnings hidden, mass actions will work except for indent. Could be supported.
tiles needs updated to remove deprecated functions and implement indent, but our tests for it are probably correct. With all warnings hidden, mass actions will work except for indent. Could be supported.
onetopic needs updated to remove deprecated functions and implement indent, but our tests for it are probably correct. With all warnings hidden, mass actions will work except for indent. Could be supported.
flexsections needs updated to remove deprecated functions and implement indent, but our tests for it are probably correct. In its current state, it breaks Moodle severely and should not be supported yet.

@Syxton Syxton deleted the port_behat_changes_to_40 branch October 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants