Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version for 4.0 release #24

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Bump version for 4.0 release #24

merged 1 commit into from
Apr 18, 2022

Conversation

PhMemmel
Copy link
Collaborator

@PhMemmel PhMemmel commented Apr 17, 2022

For the 7.0.0 release of the plugin I added the requirement for the current moodle 4.0 release version. Ideally, we could pull a release before the official moodle 4.0 release (April 19th) to acquire the early bird badge, of course only, if we do not find any bugs while testing.

@Syxton
Speaking of testing: I cannot run behat tests in my dev environment currently in 4.0 for some reason I cannot tell (moodlehq/moodle-docker#207). Can you doublecheck if the tests are passing in an environment with all course formats installed we are currently trying to support? Maybe even after merging #22? :-) Thanks in advance!

BTW: I tested basic formats topics, weekly and topcoll manually. Onetopic and tiles are still pretty buggy but have not been updated to 4.0 yet anyway, so users trying to use this ATM have other problems than block_massaction :-) Or let's say: It's basically working, but drag&drop support throws a lot of errors. We could leave both as supported plugins as I'm pretty confident that we won't have many problems with that as soon as the plugin maintainers have fixed them, but if you prefer to drop it for the moment, I'm also happy with that.

@PhMemmel PhMemmel requested a review from Syxton April 17, 2022 21:05
@Syxton Syxton merged commit 0d16237 into master Apr 18, 2022
@Syxton
Copy link
Owner

Syxton commented Apr 18, 2022

@PhMemmel Just wanted to communicate really quick that I had to bump the 4.0 version to 2022041800 because the v6.0.1 was already considered the 2022041700 version. So for all possible future 3.9-3.11 releases, we will have to stay under the 20220414xx area. The master branch can continue to proceed on version #'s as normal. Thanks again for all your work! v7 and v6.0.1 are now released into the wild!

@PhMemmel
Copy link
Collaborator Author

@Syxton Thank you! Just to be sure: You are probably talking about 20220417xx, not 20220414xx we have to stay under for 3.9-3.11 fixes?

@Syxton
Copy link
Owner

Syxton commented Apr 18, 2022

@PhMemmel yeah, it is still an early Monday here. Yes I did mean 20220417xx

@Syxton Syxton deleted the bump_version_for_40_release branch October 25, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants