-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement uploading <project_uuid>.hazmapper to tapis. #54
Conversation
It looks like there should also be a migration in here too? The additional fields in the project model will need one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just note two follow on things:
- comment about logging
- potentially deriving 'system_name' on the front end instead of having in model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one comment to consider and also for 3038e1d, is there a migration that goes along with it (as we have an early commit of this branch deployed on staging). 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 💯
Overview:
Implement saving the project file to tapis.
PR Status:
Related Jira tickets:
Summary of Changes:
Adds necessary route/service for the upload process and a new tapis interaction (create file and delete) in
agave.py
Also added
system_path
,system_id
,system_name
to the project model for creating a link to designsafe projectsTesting Steps:
Notes:
I wasn't sure how to test the Tapis part. I've tried creating a mock like the
agave_utils_with_geojson_file_mock
but wasn't sure if that could update on making the call.