-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add save to file functionality. #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🥇 Left some comments to consider.
Lots of my comments have suggestions for renaming things. I'm not certain though if my suggestions are any good. So I don't know if you (and @reptillicus ) consider what I wrote and if names need to be changed. Or if we can poll Craig for his opinion. Or just wait till we get feedback from Tracy.
src/app/components/modal-create-project/modal-create-project.component.html
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.html
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.html
Outdated
Show resolved
Hide resolved
src/app/components/modal-create-project/modal-create-project.component.ts
Outdated
Show resolved
Hide resolved
Can we pull the "Make map public" button to the left and add a divider or something before the Export Map and Delete buttons ? |
…Cloud/hazmapper into task/DES-1929-save-to-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 💯 The new layout of the Manage component looks very nice; a great improvement!
I think the few comments I have are very minor and can be stuck in a follow on ticket (and in some cases ignored). I guess take a look and see what you think.
Overview:
Adds exporting to tapis systems and linking with DS projects.
PR Status:
Related Jira tickets:
Summary of Changes:
Added three different scenarios of "saving/exporting", The first is exporting a file for an existing map. If you select a project system, it will allow you to link to that project. The second case is when creating a project. You will be able to link to a project system and create the file (in its root), The third case is for observable projects (assuming that the observable project is in a DS project). When creating, it should automatically create the link and the file.
Testing Steps:
Exporting
<uuid>.hazmapper
file of the current project is created.Creating a map
Creating an observable project
UI Photos:
Notes: