Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save to file functionality. #50

Merged
merged 39 commits into from
Jun 1, 2021
Merged

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Apr 8, 2021

Overview:

Adds exporting to tapis systems and linking with DS projects.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added three different scenarios of "saving/exporting", The first is exporting a file for an existing map. If you select a project system, it will allow you to link to that project. The second case is when creating a project. You will be able to link to a project system and create the file (in its root), The third case is for observable projects (assuming that the observable project is in a DS project). When creating, it should automatically create the link and the file.

Testing Steps:

  1. Use the geoapi branch that supports this (Implement uploading <project_uuid>.hazmapper to tapis. geoapi#54)

Exporting

  1. After creating a project (without the link option)
  2. Click the "Export map" button in the users/manage panel.
  3. Select a system & folder,
  4. Confirm that a <uuid>.hazmapper file of the current project is created.
  5. Try again selecting a project system and confirm that the file and a link to that project is created (on the top left control-bar and on the manage panel.
  6. Also try creating with an already exported map.
  7. This should prompt you to confirm that the file gets removed in the previously saved location also the link to the project.

Creating a map

  1. Try creating a project with the "Export Project" checked
  2. After creation, confirm that the map is linked to the selected project.

Creating an observable project

  1. Create an observable map from a rapid project in a DS project.
  2. Confirm that both file and link are created.

UI Photos:

Screenshot_2021-04-21 HazMapper
localhost_4200_ (2)
localhost_4200_ (1)
localhost_4200_

Notes:

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥇 Left some comments to consider.

Lots of my comments have suggestions for renaming things. I'm not certain though if my suggestions are any good. So I don't know if you (and @reptillicus ) consider what I wrote and if names need to be changed. Or if we can poll Craig for his opinion. Or just wait till we get feedback from Tracy.

@reptillicus
Copy link
Contributor

Can we pull the "Make map public" button to the left and add a divider or something before the Export Map and Delete buttons ?

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 💯 The new layout of the Manage component looks very nice; a great improvement!

I think the few comments I have are very minor and can be stuck in a follow on ticket (and in some cases ignored). I guess take a look and see what you think.

@duckonomy duckonomy merged commit c80903a into master Jun 1, 2021
@taoteg taoteg deleted the task/DES-1929-save-to-file branch July 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants