Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/DES-2240 access to streetview #85

Merged
merged 10 commits into from
Apr 23, 2022
Merged

Task/DES-2240 access to streetview #85

merged 10 commits into from
Apr 23, 2022

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

This is an incremental PR for DES-2240 that adds initial unit tests but does not add any access changes.

Added basic unit tests for:

  • StreetviewServiceResources
  • StreetviewServiceResource
  • StreetviewOrganizationResources (just POST but not GET as that isn't used)
  • StreetviewOrganizationResource. (just DELET but not PUT as that isn't used)

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Add unit tests
  • Remove an unused route
  • Change some working related to streetview resources

Testing Steps:

Run unit tests

@nathanfranklin nathanfranklin changed the title Task/DES-240 access to streetview Task/DES-2240 access to streetview Apr 22, 2022
duckonomy
duckonomy approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@duckonomy duckonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run 💯
StreetviewServiceResource is good 👍🏼

@nathanfranklin nathanfranklin merged commit 3544c56 into DES-1828-streetview-authentication Apr 23, 2022
duckonomy added a commit that referenced this pull request Apr 27, 2022
@duckonomy @nathanfranklin
task/DES-1828 Streetview (#46)
441d5c8 
* Basic authentication for streetview services.

* Basic uploading

* Implement api for exposing mapillary sequences and fix file transfer.

* Improve mapillary uploads.

* Fix streetview tests

* Add progress notification tests.

* Upload sequence typo.

* Fix notification logs.

* Fix streetview sequence update request

* Add organization uploads.

* Add kube variable for mapillary.

* Add progress cleanup after aborting on error.

* Fix organization temporarily.

* Refactor and fix.

* Fixes.

* Resolve merge conflict.

* Fix notification route delete test.

* Add better logs for streetview related exceptions.

* Port to mapillary v4 and cleanup.

* Adjust changes to mapillary_tools.

* Fix comments and api docs

* New Migrations

* Revert changes for migration.

* Revert unnecessary changes.

* New migrations.

* string env variable

* Delete streetview if it exists.

* Remove uniqueness constraint from streetview service name

* Add merge migration

* Handle different mapillary keys and add project link for streetview instances.

* Make streetview sequences map features.

* Fix kube/Makefile.

* Add surrounding quotes for mapillary env vars.

* Asset uuid for streetview features.

* Use correct sequence_id for creating feature assets.

* Make add organization_id field for streetivew sequences.

* Remove unused route

* Update some docstr and variables for streetview service objects

* Remove public routes for streetview endpoints.

* Update unit tests related to streeetview service resources

* Rename variables and docstr to use streetview service resource wording

* Rename things related to resources

* Add tests for creating and delting organizations

* Skip two tests

* Fix formatting

* Fix linting issue

* Add image id for streetview assets.

* Task/DES-2240 access to streetview (#85)

* Remove unused route

* Update some docstr and variables for streetview service objects

* Update unit tests related to streeetview service resources

* Rename variables and docstr to use streetview service resource wording

* Rename things related to resources

* Add tests for creating and delting organizations

* Skip two tests

* Fix formatting

* Fix linting issue

* Add delete instance test

* Add additional tests

* Remove as unused

* Revert "Merge branch 'task/DES-2240-access-to-streetview2' into DES-1828-streetview-authentication"

This reverts commit 963b87d, reversing
changes made to 3544c56.

* Change routes to make easier maintenance.

* Fix organization routes.

* Groundwork for process task notifications.

* Move streetview tasks back to streetview task file.

* Change docstring for streetview exceptions.

* Remove unnecessary text.

* Resolve feedback.

* Remove file.

* Remove file.

* Remove file.

* Remove file.

* Remove file.

* Correct wording.

* Update tasks for streetview progress.

* Remove unused function.

* Remove unused get user route.

* Remove unused get progress methods.

* Move streetview api exception handling to app.py.

* Error in app.py.

* Update mapillary tools to pin hash

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
duckonomy added a commit that referenced this pull request Apr 27, 2022
@nathanfranklin @duckonomy
Task/DES-2240: Add checks for access and additional test for streetvi…
3d77f42 
…ew routes (#86)

* Bug/DES-2185: Fix filtering query. (#76)

* Fix filtering query.

* Include filter for no_asset_vector.

* Update geoapi/services/projects.py

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>

* Update geoapi/services/projects.py

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>

* Update geoapi/services/projects.py

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>

* Update relase notes for v2.6

* Fix nullable value (#84)

Autogenerated migration was edited and this column need to be updated
to match that

* Fix changelog

* Add delete instance tests

* Add additional tests

* Remove as unused

* Fix notification tests

* Update tests to match recent route changes

* Add publish test

* Ensure user is authed

* Check access on some streetview service-related routes

* Add more access control and related tests

* Add test for publish without service

* task/DES-1828 Streetview (#46)

* Basic authentication for streetview services.

* Basic uploading

* Implement api for exposing mapillary sequences and fix file transfer.

* Improve mapillary uploads.

* Fix streetview tests

* Add progress notification tests.

* Upload sequence typo.

* Fix notification logs.

* Fix streetview sequence update request

* Add organization uploads.

* Add kube variable for mapillary.

* Add progress cleanup after aborting on error.

* Fix organization temporarily.

* Refactor and fix.

* Fixes.

* Resolve merge conflict.

* Fix notification route delete test.

* Add better logs for streetview related exceptions.

* Port to mapillary v4 and cleanup.

* Adjust changes to mapillary_tools.

* Fix comments and api docs

* New Migrations

* Revert changes for migration.

* Revert unnecessary changes.

* New migrations.

* string env variable

* Delete streetview if it exists.

* Remove uniqueness constraint from streetview service name

* Add merge migration

* Handle different mapillary keys and add project link for streetview instances.

* Make streetview sequences map features.

* Fix kube/Makefile.

* Add surrounding quotes for mapillary env vars.

* Asset uuid for streetview features.

* Use correct sequence_id for creating feature assets.

* Make add organization_id field for streetivew sequences.

* Remove unused route

* Update some docstr and variables for streetview service objects

* Remove public routes for streetview endpoints.

* Update unit tests related to streeetview service resources

* Rename variables and docstr to use streetview service resource wording

* Rename things related to resources

* Add tests for creating and delting organizations

* Skip two tests

* Fix formatting

* Fix linting issue

* Add image id for streetview assets.

* Task/DES-2240 access to streetview (#85)

* Remove unused route

* Update some docstr and variables for streetview service objects

* Update unit tests related to streeetview service resources

* Rename variables and docstr to use streetview service resource wording

* Rename things related to resources

* Add tests for creating and delting organizations

* Skip two tests

* Fix formatting

* Fix linting issue

* Add delete instance test

* Add additional tests

* Remove as unused

* Revert "Merge branch 'task/DES-2240-access-to-streetview2' into DES-1828-streetview-authentication"

This reverts commit 963b87d, reversing
changes made to 3544c56.

* Change routes to make easier maintenance.

* Fix organization routes.

* Groundwork for process task notifications.

* Move streetview tasks back to streetview task file.

* Change docstring for streetview exceptions.

* Remove unnecessary text.

* Resolve feedback.

* Remove file.

* Remove file.

* Remove file.

* Remove file.

* Remove file.

* Correct wording.

* Update tasks for streetview progress.

* Remove unused function.

* Remove unused get user route.

* Remove unused get progress methods.

* Move streetview api exception handling to app.py.

* Error in app.py.

* Update mapillary tools to pin hash

Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>

Co-authored-by: Ian Park <contact@duckonomy.com>
@nathanfranklin nathanfranklin deleted the task/DES-2240-access-to-streetview branch May 19, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckonomy duckonomy duckonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanfranklin @duckonomy