Bug/DES-2185: Fix filtering query. #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
There was a problem hiding this comment.
@duckonomy and I talked on slack about how to incorporate features without assets in the frontend and the behavior if non asset type was selected.
nathanfranklin
requested changes
Mar 9, 2022
Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com>
duckonomy
added a commit
that referenced
this pull request
Apr 27, 2022
…ew routes (#86) * Bug/DES-2185: Fix filtering query. (#76) * Fix filtering query. * Include filter for no_asset_vector. * Update geoapi/services/projects.py Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com> * Update geoapi/services/projects.py Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com> * Update geoapi/services/projects.py Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com> Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com> * Update relase notes for v2.6 * Fix nullable value (#84) Autogenerated migration was edited and this column need to be updated to match that * Fix changelog * Add delete instance tests * Add additional tests * Remove as unused * Fix notification tests * Update tests to match recent route changes * Add publish test * Ensure user is authed * Check access on some streetview service-related routes * Add more access control and related tests * Add test for publish without service * task/DES-1828 Streetview (#46) * Basic authentication for streetview services. * Basic uploading * Implement api for exposing mapillary sequences and fix file transfer. * Improve mapillary uploads. * Fix streetview tests * Add progress notification tests. * Upload sequence typo. * Fix notification logs. * Fix streetview sequence update request * Add organization uploads. * Add kube variable for mapillary. * Add progress cleanup after aborting on error. * Fix organization temporarily. * Refactor and fix. * Fixes. * Resolve merge conflict. * Fix notification route delete test. * Add better logs for streetview related exceptions. * Port to mapillary v4 and cleanup. * Adjust changes to mapillary_tools. * Fix comments and api docs * New Migrations * Revert changes for migration. * Revert unnecessary changes. * New migrations. * string env variable * Delete streetview if it exists. * Remove uniqueness constraint from streetview service name * Add merge migration * Handle different mapillary keys and add project link for streetview instances. * Make streetview sequences map features. * Fix kube/Makefile. * Add surrounding quotes for mapillary env vars. * Asset uuid for streetview features. * Use correct sequence_id for creating feature assets. * Make add organization_id field for streetivew sequences. * Remove unused route * Update some docstr and variables for streetview service objects * Remove public routes for streetview endpoints. * Update unit tests related to streeetview service resources * Rename variables and docstr to use streetview service resource wording * Rename things related to resources * Add tests for creating and delting organizations * Skip two tests * Fix formatting * Fix linting issue * Add image id for streetview assets. * Task/DES-2240 access to streetview (#85) * Remove unused route * Update some docstr and variables for streetview service objects * Update unit tests related to streeetview service resources * Rename variables and docstr to use streetview service resource wording * Rename things related to resources * Add tests for creating and delting organizations * Skip two tests * Fix formatting * Fix linting issue * Add delete instance test * Add additional tests * Remove as unused * Revert "Merge branch 'task/DES-2240-access-to-streetview2' into DES-1828-streetview-authentication" This reverts commit 963b87d, reversing changes made to 3544c56. * Change routes to make easier maintenance. * Fix organization routes. * Groundwork for process task notifications. * Move streetview tasks back to streetview task file. * Change docstring for streetview exceptions. * Remove unnecessary text. * Resolve feedback. * Remove file. * Remove file. * Remove file. * Remove file. * Remove file. * Correct wording. * Update tasks for streetview progress. * Remove unused function. * Remove unused get user route. * Remove unused get progress methods. * Move streetview api exception handling to app.py. * Error in app.py. * Update mapillary tools to pin hash Co-authored-by: Nathan Franklin <nathan.franklin@gmail.com> Co-authored-by: Ian Park <contact@duckonomy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Changed db query to allow multiple asset parameters instead of a single one at a time.
PR Status:
Related Jira tickets:
Summary of Changes:
Modified the sql query to adjust to multiple asset type selection.
Testing Steps:
Notes: