Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/DES-2185: Fix filtering query. #82

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Bug/DES-2185: Fix filtering query. #82

merged 4 commits into from
Apr 12, 2022

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Feb 21, 2022 •
edited
Loading

Overview:

Change asset filter interface so that all filter types are initially selected (checkbox behavior rather than radio, see image).

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added an enabledAssetTypes array in the filters-service and changed the query to the server to be a comma separated string.

Testing Steps:

  1. Test with Bug/DES-2185: Fix filtering query. geoapi#76
  2. Ensure that, on initial load, the assets are all displayed correctly.
  3. Ensure that each asset type is filtered out when unselected.

UI Photos:

Screenshot from 2022-02-21 16-45-59

Notes:

@duckonomy duckonomy mentioned this pull request Feb 21, 2022
Merged
3 tasks
nathanfranklin
nathanfranklin approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@duckonomy duckonomy merged commit a5740ea into master Apr 12, 2022
@nathanfranklin nathanfranklin deleted the bug/DES-2185-filtering-bug branch December 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckonomy @nathanfranklin