Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101: Portal Nav #226

Merged
merged 2 commits into from
May 20, 2021
Merged

GH-101: Portal Nav #226

merged 2 commits into from
May 20, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 20, 2021 •
edited
Loading

Overview

Redesign the portal nav link / menu toggle.

Issue

GH-101

Changes

  • Use new portal env() vars for nav padding.
  • No custom logo width (related to portal nav via navbar padding).
  • Remove border between search and portal nav.
  • Add Portal nav styles.
  • Add new portal env() vars for nav padding.
  • Comment on header link background color env() var value.
  • Add new header env() var for portal nav background color.
  • Revert/Remove commented Frontera code.

Screenshots

Skipped.

Testing

Logged In

  1. Build CSS with CMS setting/secret _THEME set to None.
  2. Confirm Portal nav link style matches CMS-Common Components > Navigation Light-mode.
  3. Build CSS with CMS setting/secret _THEME set to 'has-dark-logo'.
  4. Confirm Portal nav link style matches CMS-Common Components > Navigation Dark-mode.

Logged Out

  1. Build CSS with CMS setting/secret _THEME set to None.
  2. Confirm Portal menu toggle style matches CMS-Common Components > Navigation Light-mode.
  3. Build CSS with CMS setting/secret _THEME set to 'has-dark-logo'.
  4. Confirm Portal menu toggle style matches CMS-Common Components > Navigation Dark-mode.

Notes

Known Issues

  1. Mobile Nav. The Portal nav link / menu toggle looks bad in header mobile nav. Expect fix in separate PR.

@wesleyboar
GH-101: taccsite_custom: Mostly Revert its 64a5d03
45c0661
@wesleyboar
GH-101: Portal Nav
fcf2e82 
- Use new portal env() vars for nav padding.
- No custom logo width (related to portal nav via navbar padding).
- Remove border between search and portal nav.
- Add Portal nav styles.
- Add new portal env() vars for nav padding.
- Comment on header link bkgd color env() var value.
- Add new header env() var for portal nav bkgd color.
@wesleyboar wesleyboar changed the base branch from main to task/GH-101-header-redesign May 20, 2021 00:13
@wesleyboar wesleyboar marked this pull request as ready for review May 20, 2021 00:58
@wesleyboar wesleyboar self-assigned this May 20, 2021
@wesleyboar wesleyboar linked an issue May 20, 2021 that may be closed by this pull request
Header Redesign → FP-1458 #101
Closed
@wesleyboar wesleyboar merged commit 8ec39d0 into task/GH-101-header-redesign May 20, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--portal-nav branch May 20, 2021 00:59
@wesleyboar wesleyboar changed the title Task/gh 101 header redesign portal nav GH-101: Portal Nav May 20, 2021
@wesleyboar wesleyboar mentioned this pull request May 21, 2021
Draft
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleyboar wesleyboar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458
1 participant
@wesleyboar