Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header Redesign → FP-1458 #101

Closed
wesleyboar opened this issue Jan 29, 2021 · 1 comment · Fixed by #220, #226, #227, #228 or #239
Closed

Header Redesign → FP-1458 #101

wesleyboar opened this issue Jan 29, 2021 · 1 comment · Fixed by #220, #226, #227, #228 or #239
Labels
effort XL Extra large effort task (~4 weeks) — does not include review time enhancement Improvements or additions to existing features priority ▲ High priority
Milestone
Frontera Redesign...

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Jan 29, 2021 •
edited
Loading

Status

Migrated to FP-1458.

Goal

Direction

Unless requested, avoid performing technical debt and nice to haves, like:

The styles are not ideal, but there are maintainable. The markup is duplicated, but the duplication is much less than it was before you took over.

Reference
@wesleyboar wesleyboar added enhancement Improvements or additions to existing features priority ▼ Low priority effort S Small effort task (~½ a week) — does not include review time tacc labels Jan 29, 2021
@wesleyboar wesleyboar added priority ▲ High priority and removed priority ▼ Low priority labels Apr 22, 2021
@wesleyboar wesleyboar mentioned this issue Apr 27, 2021
Merged
wesleyboar added a commit that referenced this issue May 11, 2021
@wesleyboar
GH-101: Branding Bar
7b1a8cb 
- Migrate `branding_logos` CSS to `c-branding` & `c-logo`.
- In `s-header` style `.c-logo` not `.navbar-brand` .
- Update and format markup for `header_branding` and `header_logo`.
- Comment on now-unused secrets values.
@wesleyboar wesleyboar mentioned this issue May 11, 2021
Closed
wesleyboar added a commit that referenced this issue May 11, 2021
@wesleyboar
GH-101: Branding Bar
3e4a501 
- Migrate `branding_logos` CSS to `c-branding` & `c-logo`.
- In `s-header` style `.c-logo` not `.navbar-brand`.
- Update and format markup for `header_branding` and `header_logo`.
- Comment on now-unused secrets values.
This was referenced May 12, 2021
Merged
Merged
wesleyboar added a commit that referenced this issue May 12, 2021
@wesleyboar
Merge pull request #221 from TACC/task/GH-101-header-redesign--env-va…
03a9482 
…riables
wesleyboar added a commit that referenced this issue May 13, 2021
@wesleyboar
Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…
4533c5f 
…design--branding-bar
wesleyboar added a commit that referenced this issue May 13, 2021
@wesleyboar
Merge pull request #220 from TACC/task/GH-101-header-redesign--brandi…
80ed3c0 
…ng-bar

GH-101: Branding Bar
This was linked to pull requests May 13, 2021
GH-101: Branding Bar #220
Merged
GH-101/FP-1458: Header Redesign #222
Draft
@wesleyboar wesleyboar mentioned this issue May 13, 2021
Closed
wesleyboar added a commit that referenced this issue May 13, 2021
@wesleyboar
GH-101: Navigation Bar (Partially Complete)
b2cec49 
- Remove now-moot taccsite_custom:frontera-cms search bar font sizes.
- Support CSS custom selectors (known external bug).
- Test CSS custom selectors (known external bug).
- Remove outdated comment from `c-branding`.
- Set `c-logo` image height in component stylesheet.
- Add TODO for `html { font-size: 62.5%; }`
- Add arrow "mixin" (note: using `%-arrow` syntax).
- Redesign header (but not dropdowns and not portal nav).
- Remove now-moot `s-portal-nav` styles.
- Add & Update header env variables for themes.
- Perform "GH-129: Do Not Support CMS Menu Nav Link & Dropdown".
wesleyboar added a commit that referenced this issue May 14, 2021
@wesleyboar
GH-101: Navigation Bar (Fix CMS Nav Bug in Docs)
a9ec66a 
Prevent dropdown link from being flagged as active.
wesleyboar added a commit that referenced this issue May 14, 2021
@wesleyboar
GH-101: Navigation Bar (Fix Color Bug/s in Docs)
23e3db2 
- (Real Fix) Ensure colors are available to Docs.
- (Possible Fix) Ensure correct colors are available to Portal.\*

\* The Portal has its own settings/color.css that is almost identical.
wesleyboar added a commit that referenced this issue Aug 20, 2021
@wesleyboar
Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…
7cf8137 
…design--mobile-nav-layout-2
wesleyboar added a commit that referenced this issue Aug 23, 2021
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
c31b7e6 
…ask/GH-101-header-redesign
wesleyboar added a commit that referenced this issue Aug 23, 2021
@wesleyboar
Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…
bc09ec8 
…design--mobile-nav-layout-2
wesleyboar added a commit that referenced this issue Sep 2, 2021
@wesleyboar
GH-101: Build settings.json before CSS
fe9de08
wesleyboar added a commit that referenced this issue Sep 2, 2021
@wesleyboar
Quick: Remove errant comma in settings
2498c27 
I am suprised more branches aren't failing, given that this caused a server crash on task/GH-101.
wesleyboar added a commit that referenced this issue Sep 2, 2021
@wesleyboar
Merge branch 'main' into task/GH-101-header-redesign
6401683
wesleyboar added a commit that referenced this issue Sep 2, 2021
@wesleyboar
Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…
3a5c088 
…design--mobile-nav-layout-2
wesleyboar added a commit that referenced this issue Sep 9, 2021
@wesleyboar
GH-101: New mobile portal and nav menu design
73ddd2e 
Known Issues:
1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar.
2. On CMS, mobile navbar opens and closes too slow.
3. login link is a bit too wide
wesleyboar added a commit that referenced this issue Sep 9, 2021
@wesleyboar
GH-101: New mobile portal and nav menu design
b2e59db 
Known Issues:
1. On CMS & Docs, `s-header__menu-backdrop` adds gap in navigation bar.
2. On CMS, mobile navbar opens and closes too slow.
3. The login link is a bit too wide.
4. Code is difficult to follow (but documented).
wesleyboar added a commit that referenced this issue Sep 10, 2021
@wesleyboar
GH-101: Add TODO.md to track remaining work
c738a6a
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
2e4c19f 
…ask/GH-101-header-redesign
wesleyboar added a commit that referenced this issue Sep 23, 2021
@wesleyboar
Merge branch 'main' into task/GH-101-header-redesign
b786c3c
wesleyboar added a commit that referenced this issue Sep 23, 2021
@wesleyboar
Merge branch 'task/GH-101-header-redesign' into task/GH-101-header-re…
403567c 
…design--mobile-nav-layout-2
wesleyboar added a commit that referenced this issue Sep 27, 2021
@wesleyboar
Merge branch 'main' into task/GH-101-header-redesign
73e6190
@wesleyboar wesleyboar mentioned this issue Oct 26, 2021
Merged
wesleyboar added a commit that referenced this issue Nov 4, 2021
@wesleyboar
Merge branch 'main' into task/GH-101-header-redesign
9d5c68a
@wesleyboar wesleyboar changed the title Header Redesign Header Redesign → FP-1458 Jan 12, 2022
@wesleyboar wesleyboar mentioned this issue Apr 28, 2022
Merged
@wesleyboar wesleyboar mentioned this issue Oct 21, 2022
Merged
@wesleyboar
Copy link
Member Author

Migrated to JIRA as FP-1458 a long time ago.

@wesleyboar wesleyboar unpinned this issue Aug 30, 2023
@wesleyboar wesleyboar mentioned this issue Mar 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort XL Extra large effort task (~4 weeks) — does not include review time enhancement Improvements or additions to existing features priority ▲ High priority
Projects
None yet
Milestone
Frontera Redesign Phase 1
1 participant
@wesleyboar