Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101: Navigation Bar (Mobile Menus & Toggle) #228

Merged
merged 1 commit into from
May 24, 2021
Merged

GH-101: Navigation Bar (Mobile Menus & Toggle) #228

merged 1 commit into from
May 24, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 24, 2021 •
edited
Loading

Overview

  • Finish styling mobile navbar menu.
  • Style mobile navbar menu toggle button.
  • Style mobile brand bar.
  • Style mobile brandbar and navbar height.

The search bar, icons, and portal nav have not been re-styled yet.

Issues

Changes

  • New: Import all icon styles (not just some).
  • New: Support mobile brandbar.
  • New: Support mobile vs. desktop navbar & brandbar heights.
  • New: Support mobile logo.
  • New: Support mobile navbar collabsible menu.
  • New: Add new theme constants for navbar & branbar heights.
  • New: Add navbar menu button text.

Testing

  1. Resize screen width.
  2. Compare the following elements to design when header navigation is mobile versus desktop:
    • brand bar height
    • brand bar separators height
    • brand bar images heights
    • nav bar height
    • nav bar menu background
    • nav bar menu toggle icon & text
    • nav bar menu link alignment

@wesleyboar
GH-101: Navigation Bar (Mobile Menus & Toggle)
b8691d6 
- Import all icon styles (not just some).
- Support mobile brandbar.
- Support mobile vs. desktop navbar & brandbar heights.
- Support mobile logo.
- Support mobile navbar collabsible menu.
- Add new theme constants for navbar & branbar heights.
- Add navbar menu button text.
@wesleyboar wesleyboar self-assigned this May 24, 2021
@wesleyboar wesleyboar merged commit a4558b6 into task/GH-101-header-redesign May 24, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--mobile-nav branch May 24, 2021 20:48
@wesleyboar wesleyboar linked an issue May 24, 2021 that may be closed by this pull request
Header Redesign → FP-1458 #101
Closed
@wesleyboar wesleyboar mentioned this pull request May 24, 2021
Draft
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleyboar wesleyboar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header Redesign → FP-1458
1 participant
@wesleyboar