GH-195: Clone Portal Nav

[wesleyboar]

Status

Postponing merge to ensure no other Portal CMS accidentally deploys this without TACC/Core-Portal PR #390.

• Must only be deployed with or after TACC/Core-Portal PR #390.
• Should be deployed with taccaci/frontera-tech-docs PR #18.

Overview

Replace replicated Portal nav template code and unique update script with common code to load external markup.

Related

Issues

• Portal & Docs: FP-1015
• CMS: CMS & Docs to Clone—not Recreate—Portal Nav #195

PRs

• CMS: GH-195: Clone Portal Nav #211
• Portal: FP-1015: Allow Portal Nav to be Cloned Core-Portal#390
• Docs: https://bitbucket.org/taccaci/frontera-tech-docs/pull-requests/17/fp-1015-clone-portal-nav

Changes

• Minor: Add comment about deprecation of nav_portal.js.
• New: Replace Portal nav markup with use of importHTML to load nav from Portal.

Testing

Notice: Local testing should not be necessary if this and related code is deployed to Frontera Dev via FP-1032.

1. Test on dev.fronteraweb.tacc.utexas.edu or local environment (instructions).
2. For CMS & Docs:
   1. If not logged in, then portal nav should load as "Log in" link.
3. For CMS & Portal & Docs:
   1. If logged in, then portal nav should load as "[username]" dropdown menu link.
   2. If logged in, then dropdown menu link should able able to open and close as it has.
   3. When loading page with no browser cache, portal nav should not load too much later than search.*
4. For Docs:
   1. Ensure header text is white, not gray.
5. For Portal:
   1. (As of 2020-04-28, this feature is not yet available to test on dev.fronteraweb.tacc.utexas.edu.)
      When logged in as staff, confirm "Onboarding Admin" is in the portal nav dropdown for staff (how to become staff).

Footnotes

* Were it to load too much later, then the user experience is affected. Loading less than a second later (if not at the same time or earlier) is acceptable (confirmed with Design via video comparison). The solution, were it to load too much later, may be to animate its appearance such that it slides in from the right, pushing search to the left to make space for itself. Branch with animation solution is task/FP-1015-GH-195-clone-portal-nav--animate-load.

Screenshots

CMS

Videos

Local.CMS.Fast.mov

Local.CMS.Slow.mov

Portal

Videos

Local.Portal.Fast.mov

Local.Portal.Slow.mov

Docs

Videos

Local.Docs.Fast.mov

Local.Docs.Slow.mov

Onboarding Admin

This new link requires (A) latest of Portal branch (since TACC/Core-Portal@f82b29b) and (B) that your user is staff.

Notes

Please mention discrepancies you may notice beyond the loading of the Portal nav, but unless it is related to the code change, such discrepancies will likely be recorded for another ticket to resolve.

Known Issues

• CMS: Different font for header text. Caused by GH-157: Change Standard Font (+ Some Polish) #185.
• Portal: Larger search bar. Cause unknown.
• Docs: Gray background on bottom of header before complete header load. Cause unknown.

Existing Tickets

• Make Core (not just Frontera) Header Searchbar Styles Match Across Sites #62: Frontera/Core Header Differences
• Header Redesign → FP-1458 #101: Header Redesign
• Navigation Styles via UI Component #12: Nav Component

[wesleyboar]

Explanation
This file is kept temporarily in case a misfire deploy does not deploy the desired Docs image and Docs is still looking for this.

[rstijerina]

LGTM

[wesleyboar]

Postponing merge to ensure no other Portal CMS accidentally deploys this without TACC/Core-Portal#390. For more information, see "Status" (at the top of this comment's PR).

[wesleyboar]

Considering reasonably safe to merge because deploys are pinned to docker tags (so don't default to bleeding edge main), and 3dem and Frontera and Core deploy process is managed by @rstijerina who is aware of this dependency, and ProTX is unlikely to have a re-deploy of CMS without Portal (because I am currently the one building CMS docker images for ProTX and I am aware of the dependency).