Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes via Settings (Light Header Navbar) #191

Closed
wesleyboar opened this issue Apr 13, 2021 · 0 comments · Fixed by #192 · May be fixed by #222
Closed

Themes via Settings (Light Header Navbar) #191

wesleyboar opened this issue Apr 13, 2021 · 0 comments · Fixed by #192 · May be fixed by #222
Assignees
@wesleyboar
Labels
effort XS Extra small effort task (~¼ a week) — does not include review time feature A new feature or replacement of present feature paused Started but not actively in progress priority ▲ High priority

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Apr 13, 2021 •
edited
Loading

Alternative

Goal

Support a light navbar for dark logos.*

* Just the bottom navigation bar, not the branding bar nor the footer.

Pull Requests

Direction

Use build-time variables and a THEME configuration value.

Archived
  1. In secrets, create a THEME variable.
  2. In templates, add a class t-{{THEME}} on the html.
  3. In styles, set colors for headers and footers depending on the new class.

Reference

Design

Do Something Like This

Light Theme
Dark Theme

Do Not Do This

TACC Theme Light
TACC Theme Dark
@wesleyboar wesleyboar added effort XS Extra small effort task (~¼ a week) — does not include review time feature A new feature or replacement of present feature priority ▲ High priority labels Apr 13, 2021
@wesleyboar wesleyboar self-assigned this Apr 13, 2021
wesleyboar added a commit that referenced this issue Apr 13, 2021
@wesleyboar
GH-191: Add THEME that supports light/dark
4817dd2
@wesleyboar wesleyboar changed the title Support Light & Dark Theme Support Light Navbar Apr 13, 2021
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Replace THEME with _LOGO "is_dark"
e88946f
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Fix light header bugs
5fb16a6 
- Restore missing line between search bar and portal nav
- (Simplify CSS of line between search bar and portal nav)
- Do not let background show through search bar.
- (This happens now because of a color replacement.)
@wesleyboar wesleyboar mentioned this issue Apr 14, 2021
Merged
10 tasks
@wesleyboar wesleyboar linked a pull request Apr 14, 2021 that will close this issue
GH-191: Theme (for ProTX Light Header & TACC Blue Header) #192
Merged
10 tasks
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Reduce unnecessary changes
7a419b3
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Manually Revert to Using THEME
651a110
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Cleanup
a2a5834
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Cleanup
cde3be7
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Use None instead of empty string
aa3a06b
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
GH-191: Update taccsite_custom (maintenance)
d5a5e27
wesleyboar added a commit that referenced this issue Apr 14, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
52d0d5d
wesleyboar added a commit that referenced this issue Apr 15, 2021
@wesleyboar
GH-191: Add minimal settings API
793e10a
wesleyboar added a commit that referenced this issue Apr 15, 2021
@wesleyboar
GH-191: Allow loading CMS data via CMS script
67149c2 
So that Portal and Docs need not reinvent the wheel.
wesleyboar added a commit that referenced this issue Apr 15, 2021
@wesleyboar
GH-191: Allow loading CMS data via CMS script
0f7f9a1 
So that Portal and Docs need not reinvent the wheel.
wesleyboar added a commit that referenced this issue Apr 15, 2021
@wesleyboar
GH-191: Provide CMS script to add CMS theme class
a86a5e5 
So that Portal and Docs need not reinvent the wheel.
wesleyboar added a commit that referenced this issue Apr 16, 2021
@wesleyboar
GH-191: Add color vars site.header.css now needs
ac32c2b
@wesleyboar wesleyboar mentioned this issue Apr 16, 2021
Closed
@wesleyboar wesleyboar changed the title Support Light Navbar Support Light Header Navbar Apr 16, 2021
@wesleyboar wesleyboar mentioned this issue Apr 16, 2021
Closed
wesleyboar added a commit that referenced this issue Apr 19, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
6c46036
wesleyboar added a commit that referenced this issue Apr 19, 2021
@wesleyboar
GH-191: Undo unnecessary whitespace change
3eb2f32
wesleyboar added a commit that referenced this issue Apr 19, 2021
@wesleyboar
GH-191: Undo unnecessary whitespace change
c3922e2
@wesleyboar wesleyboar mentioned this issue Jun 17, 2021
Closed
@wesleyboar wesleyboar added the alternative Alternative solution(s) exist(s) label Jun 17, 2021
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
9353b83
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
GH-191: Update submodule to merge of main
f8028a0
wesleyboar added a commit that referenced this issue Jun 17, 2021
@wesleyboar
GH-191: Update submodule to merge of main (again)
0f25809
wesleyboar added a commit that referenced this issue Jun 19, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
6121316
wesleyboar added a commit that referenced this issue Jul 13, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
49be926
@wesleyboar wesleyboar removed the alternative Alternative solution(s) exist(s) label Jul 29, 2021
wesleyboar added a commit that referenced this issue Aug 17, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
1c111d4
wesleyboar added a commit that referenced this issue Aug 17, 2021
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
e69b89b 
…ask/GH-101-header-redesign
wesleyboar added a commit that referenced this issue Aug 23, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
ec8d78a
wesleyboar added a commit that referenced this issue Aug 23, 2021
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
c31b7e6 
…ask/GH-101-header-redesign
@wesleyboar wesleyboar changed the title (Light Header Navbar) Support Themes - via Settings Themes via Settings (Light Header Navbar) Aug 26, 2021
@wesleyboar wesleyboar added the paused Started but not actively in progress label Aug 26, 2021
This was referenced Aug 30, 2021
Closed
Merged
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
e55b260
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
0739776
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
GH-191: Fix merge conflict mistake
c71a9b0
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
GH-191: Submod: ProTX: Set 'has-dark-logo' theme
16f2092
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
GH-191: Clean up (and remove extra changes)
55d242d
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
d3ffaed
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
GH-191: Quick: Restore doc formatting typo
d9a4c44
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
2e4c19f 
…ask/GH-101-header-redesign
wesleyboar added a commit that referenced this issue Sep 21, 2021
@wesleyboar
GH-191: Undo an out-of-scope change
70a1ca3
taoteg added a commit that referenced this issue Sep 22, 2021
@taoteg
Merge pull request #192 from TACC/task/GH-191-support-light-navbar-fo…
589f1fb 
…r-dark-logos

GH-191: Theme (for ProTX Light Header & TACC Blue Header)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleyboar wesleyboar

Labels
effort XS Extra small effort task (~¼ a week) — does not include review time feature A new feature or replacement of present feature paused Started but not actively in progress priority ▲ High priority
Projects
None yet
Milestone
No milestone
1 participant
@wesleyboar