FP-1022 a.k.a. Task/gh 191 support light navbar for dark logos #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
==========================================
+ Coverage 63.99% 64.81% +0.82%
==========================================
Files 398 205 -193
Lines 11970 5102 -6868
Branches 2060 1313 -747
==========================================
- Hits 7660 3307 -4353
+ Misses 3990 1672 -2318
+ Partials 320 123 -197
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Apr 16, 2021
wesleyboar
changed the title
wesleyboar
commented
Apr 16, 2021
|
Notice: To Do's on the CMS PR (TACC/Core-CMS#192) may render this PR moot, or much simpler. |
|
This PR is moot since TACC/Core-CMS#202 performs GH-191 without editing Doc nor Portal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For ProTX, support a light navbar for dark logo. See TACC/Core-CMS#192 for complete details.
Pull Requests
CMS Projects PR: Core: GH-191: Support new theme setting Core-CMS-Resources#41Portal PR: FP-1022 a.k.a. Task/gh 191 support light navbar for dark logos #386Docs PR: https://bitbucket.org/taccaci/frontera-tech-docs/pull-requests/16/task-gh-191-support-light-navbar-for-darkRelated Jira tickets:
Summary of Changes:
docsimage to one fortask/GH-191-…branch. ← Should I do this?Testing Steps:
See TACC/Core-CMS#192.
UI Photos:
See TACC/Core-CMS#192 for all CMS & Docs & Portal screenshots.
Light Navbar For Dark Logo
Yes, I am using a light logo here. The navbar switch works. The logo is controlled by configuration already.
Notes:
Loading another script should not be a major performance issue, because we use http2 protocol, which "multi-tasks" asset downloads. If this is a performance issue, then I can use React to perform the same task (previous commits do so), but that will delay the header color swap, which is undesirable UX.