Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/gh 191 support light navbar for dark logos remove api solution #202

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 20, 2021

Overview

Update #192 to not need an update to Portal nor Docs.

Changes

  • New: Document .env file via a .env.sample.
  • New: Support native* built-time variables a.k.a. environment variables—env().
  • New: Use built-time variables to apply different theme.
  • New: Delete API.
  • New: Drop THEME from secrets.py.
  • New: Read THEME from .env.
  • New: Update s-header.css to use environment variables—env().
  • New: Improve site.header.css management of global variables a.k.a. custom properties—var().
  • New: Restore logic extracted from importHTML.js.
  • New: Delete site.css.js, setting t-{{THEME}} in template, and the urls.py API entry.

* Though the specification to assign environmental variables is far from complete, the implementation to use environmental variables (i.e. using env(…) and a --* var name prefix just like for var(…)) has already been supported in all modern browsers. We already have installed a plugin postcss-preset-env that includes the polyfill to assign environmental variables (it is postcss-env-function).

@wesleyboar wesleyboar force-pushed the task/GH-191-support-light-navbar-for-dark-logos--remove-api-solution branch from 61ea686 to c68f59c Compare April 21, 2021 00:26
@wesleyboar wesleyboar force-pushed the task/GH-191-support-light-navbar-for-dark-logos--remove-api-solution branch from c68f59c to 83bcff4 Compare April 21, 2021 01:08
@wesleyboar wesleyboar changed the base branch from task/GH-191-support-light-navbar-for-dark-logos to main April 21, 2021 01:32
Though this load would cause redundant global vars, it is explicit.

A long-term solution is unclear. A worse problem exists with font.
@wesleyboar wesleyboar changed the base branch from main to task/GH-191-support-light-navbar-for-dark-logos April 21, 2021 03:02
@wesleyboar wesleyboar marked this pull request as ready for review April 21, 2021 05:37
@wesleyboar wesleyboar merged commit 0c9bd99 into task/GH-191-support-light-navbar-for-dark-logos Apr 21, 2021
@wesleyboar wesleyboar deleted the task/GH-191-support-light-navbar-for-dark-logos--remove-api-solution branch April 21, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant