-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/FP-327 - Onboarding welcome messages #191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 58.33% 63.08% +4.74%
==========================================
Files 251 109 -142
Lines 8585 2847 -5738
Branches 1269 648 -621
==========================================
- Hits 5008 1796 -3212
+ Misses 3358 971 -2387
+ Partials 219 80 -139
Flags with carried forward coverage won't be shown. Click here to find out more. |
Please use the info color/style. It's the gray one. |
I am. Is this wrong?
|
@tacc-wbomar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. 👍
Local storage is good but do you think people will get annoyed seeing it again when they use a different computer? |
@rstijerina @jchuahtacc P.S. For the UI-curious, Reactstrap should not have chosen |
I vote "They'll live". This is a temp solution overall. If feasible, then tying the state to user account is "better", but I don't know how to do (thus critique) that, and I assumed Joon Ye found it quicker to use local storage than step into what might be an active cobweb of user data (again, I dunno). |
Yeah this is temporary. Ideally we'd tie this into the user profile in django and fold these sagas/reducers together, but in the amount of time that i had this was the most attainable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rad.
Note: Do we also want a welcome message for "Manage Account" and the unauthed tickets view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoowah!
I've asked Maytal directly. These messages were her want. https://tacc-team.slack.com/archives/GQW4Q8HLG/p1598031117004400 |
Yes, let's add one for (logged out) "Add Ticket" form—if feasible in the time available. Message Proposal:
Why so short (no info about what happens next)?:
|
And, if Maytal doesn't answer in time (y'all decide what "in time" means), then forgo or add message for Manage Account. Message Proposal:
I don't give much thought to this, because Design didn't want these to begin with. |
For time's sake, let's follow up with these in a separate task. |
Overview:
Add alert messages to each section
Message text edited by @thbrowntacc
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes: