Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-101: Environment Variables for CSS #221

Merged
merged 44 commits into from
May 12, 2021
Merged

GH-101: Environment Variables for CSS #221

merged 44 commits into from
May 12, 2021

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented May 12, 2021 •
edited
Loading

Overview

Changes, Testing, Etc.

See #192 (as of 396c018).

wesleyboar and others added 30 commits April 13, 2021 18:02
@wesleyboar
GH-191: Add THEME that supports light/dark
4817dd2
@wesleyboar
GH-191: Replace THEME with _LOGO "is_dark"
e88946f
@wesleyboar
GH-191: Fix light header bugs
5fb16a6 
- Restore missing line between search bar and portal nav
- (Simplify CSS of line between search bar and portal nav)
- Do not let background show through search bar.
- (This happens now because of a color replacement.)
@wesleyboar
GH-191: Reduce unnecessary changes
7a419b3
@wesleyboar
GH-191: Manually Revert to Using THEME
651a110
@wesleyboar
GH-191: Cleanup
cde3be7
@wesleyboar
GH-191: Use None instead of empty string
aa3a06b
@wesleyboar
GH-191: Update taccsite_custom (maintenance)
d5a5e27
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
52d0d5d
@wesleyboar
GH-191: Add minimal settings API
793e10a
@wesleyboar
GH-191: Allow loading CMS data via CMS script
0f7f9a1 
So that Portal and Docs need not reinvent the wheel.
@wesleyboar
GH-191: Provide CMS script to add CMS theme class
a86a5e5 
So that Portal and Docs need not reinvent the wheel.
@wesleyboar
GH-191: Add color vars site.header.css now needs
ac32c2b
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
6c46036
@wesleyboar
GH-191: Undo unnecessary whitespace change
c3922e2
@wesleyboar
GH-191: Frontera: Merge in main
98ff5e4
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
0d42059
@wesleyboar
GH-191: Remove API Solution
5cb4a90
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
acbc3d7
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-lo…
73dc3d5 
…gos--remove-api-solution
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
8f492c8
@wesleyboar
Merge branch 'task/GH-191-support-light-navbar-for-dark-logos' into t…
5ec0e85 
…ask/GH-191-support-light-navbar-for-dark-logos--remove-api-solution
@wesleyboar
GH-191: WIP: Apply THEME via env vars
9ad6404
@wesleyboar
GH-191: UNTESTED: Replace theme with env vars
83bcff4
@wesleyboar
GH-191: TESTED: Patch global var load in header
adf43cf 
Though this load would cause redundant global vars, it is explicit.

A long-term solution is unclear. A worse problem exists with font.
@wesleyboar
GH-191: Handle bad theme name error
9ae75aa
@wesleyboar
GH-191: Document theme in README & new .env.sample
8b03133
@wesleyboar
GH-191: Add README to css _data
e1c8c32
@wesleyboar
GH-191: Support comments in JSON
eb43205
@wesleyboar
Merge pull request #202 from TACC/task/GH-191-support-light-navbar-fo…
0c9bd99 
…r-dark-logos--remove-api-solution

Task/gh 191 support light navbar for dark logos  remove api solution
@wesleyboar
GH-191: Noop: Misc Cleanup
87704a3
@wesleyboar
GH-191: Test: Change Dep Repo URL to HTTPS
c66912b
@wesleyboar
GH-191: Revert .jsonc` ext. support
b1ebc55 
The support required `tacc-wbomar/jsonc-require` repo.
But Jenkins has credential failure if downloading from Git.
Alt: My PR to aMarCruz/jsonc-require is approved and merged.
Then the `.jsonc` support will be built into `json-require`.
SEE: aMarCruz/jsonc-require#1
@wesleyboar
GH-191: Fix: branding-seperator color
d6abd39
@wesleyboar
GH-191: Drop JSONC. Rename _data. Document themes.
647e692
@wesleyboar
GH-191: Abandon unnecessary taccsite_custom change
a492886
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
009327a
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
0727b05
@wesleyboar
GH-191: UNTESTED Use env() in branding_logos, also
7de1751 
- Remove global colors import that is redundant on Portal.
- Comment plan to remove global fonts redundant on Portal.
@wesleyboar
Quick: Update taccsite_custom from merging main
0cccb4e
@wesleyboar
Revert "GH-191: UNTESTED Use env() in branding[…]"
0dcf005 
This reverts functional parts of commit 7de1751.
This also tweaks comments for clarity.
The code tests successfully, but…
- The branding should NOT use the header nav colors.
- Which—if any—global vars should become env vars?
- How would we allow overwriting or extending themes?
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
91fba66
@wesleyboar
Merge branch 'main' into task/GH-191-support-light-navbar-for-dark-logos
b7bd69b
@wesleyboar
GH-191: Get THEME from settings.py not .env
396c018 
- __New__: Ignore dynamic settings.json.
- __New__: Add settings_to_json.py.
- __New__: Add THEME to secrets/settings.
- _Minor_: Support temp. hiding print statements.
- _Major_: Import THEME from settings.json now.
- _Minor_: Tweak theme.*.json files.
@wesleyboar wesleyboar changed the base branch from main to task/GH-101-header-redesign May 12, 2021 21:56
@wesleyboar wesleyboar merged commit 03a9482 into task/GH-101-header-redesign May 12, 2021
@wesleyboar wesleyboar deleted the task/GH-101-header-redesign--env-variables branch May 12, 2021 21:56
@wesleyboar wesleyboar restored the task/GH-101-header-redesign--env-variables branch May 12, 2021 21:56
This was referenced May 12, 2021
Draft
Merged
@wesleyboar wesleyboar changed the title Task/gh 101 header redesign env variables GH-101: Environment Variables for CSS May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar