Skip to content

Commit

Permalink
fix(core-styles): fp-1723 fix o-section--banner on safari (#29)
Browse files Browse the repository at this point in the history
* fix(o-section): fp-1723 drop trick, use easier css

* fix(o-section): fp-1723 adapt to new markup
  • Loading branch information
wesleyboar authored Jul 13, 2022
1 parent 22bbcc3 commit addafe9
Showing 1 changed file with 3 additions and 20 deletions.
23 changes: 3 additions & 20 deletions libs/core-styles/src/lib/_imports/objects/o-section.css
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ Styleguide Objects.Section

/* Modifers: Banner */

.o-section--banner[class*="o-section--layout"] { gap: 0; }
.o-section--banner.container { padding-inline: 0; }
.o-section--banner { overflow: hidden; }
.o-section--banner [class*="o-section--layout"] { gap: 0; }
.o-section--banner .container { padding-inline: 0; }
.o-section--banner.o-section { padding-block: 0; }


Expand Down Expand Up @@ -253,24 +254,6 @@ Styleguide Objects.Section



/* Tricks: Children: Banner Image */
/* FP-1462: Extract to new banner component(s) */

/* To hide section overflow with minimal side effects */
/* FAQ: Use 'clip', not 'hidden' which can affect opposite 'overflow-' value */
/* NOTE: This selector assumes only a banner section has vertical overflow */
/* CAVEAT: Any banner pop-out el's would NOT overflow atop sibling sections */
[class*="o-section--style"].o-section--banner {
/* To hide vert. overflow */
overflow-y: clip;
}
main {
/* To hide horz. overflow yet support any 'position: sticky' descendant */
overflow-x: clip;
}



/* Tricks: Modifers: Style */

/* To prevent visibly extra space beneath certain sections and footer */
Expand Down

0 comments on commit addafe9

Please sign in to comment.