fix(core-styles): fp-1723 fix o-section--banner on safari #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
changed the title
wesleyboar
changed the title
|
Merged based on approval of dependent TACC/Core-CMS#513. |
Merged
wesleyboar
added a commit
that referenced
this pull request
Jul 15, 2022
* fix(core-styles): fp-1723 fix o-section--banner on safari (#29) * fix(o-section): fp-1723 drop trick, use easier css * fix(o-section): fp-1723 adapt to new markup * feat(core-styles): tup-308, new global color (#25) * Core styles/v0.7.0 beta (#31) * Squashed commit of the following: commit 81323f7 Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Wed Jul 6 15:08:43 2022 -0500 feat(core-styles): tup-308, new global color * Squashed commit of the following: commit 4c21f96 Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Wed Jul 13 10:26:48 2022 -0500 fix(o-section): fp-1723 adapt to new markup commit 31077dc Author: Wesley Bomar <wbomar@tacc.utexas.edu> Date: Tue Jul 12 17:39:33 2022 -0500 fix(o-section): fp-1723 drop trick, use easier css * chore(core-styles): v0.7.0-beta * chore(core-styles): v0.7.0-beta .npmrc * chore(core-styles): v0.7.0-beta package…json * feat(core-styles): add git tagging to publish steps in readme * chore(core-styles): v0.7.0 * chore(core-styles): nx format:write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Changes
.o-section--bannerselectors to new markup.I changed the markup slightly in dev and pprd.1
Related
Testing / UI
See TACC/Core-CMS#513.
Notes
Released in @tacc/core-styles@0.7.0-beta via core-styles/v0.7.0-beta.
Footnotes
For details, see https://github.com/TACC/Core-CMS/pull/513. ↩