Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope Protocol Permissions to a specific protocol. #802

Closed
LiranCohen opened this issue Sep 7, 2024 · 1 comment
Closed

Scope Protocol Permissions to a specific protocol. #802

LiranCohen opened this issue Sep 7, 2024 · 1 comment

Comments

@LiranCohen
Copy link
Member

Currently ProtocolPermissions for ProtocolConfigure and ProtocolQuery are all or nothing.

We would like the ability to scope those permissions down to a specific protocol so that wallets can grant permissions for apps to query private protocols.
This was referenced Sep 8, 2024
Merged
Merged
LiranCohen added a commit that referenced this issue Sep 10, 2024
@LiranCohen
Protocol Interface Permissions (#803)
080359c 
- add delegateGrant ability to `ProtocolConfigure`
- Allow `ProtocolPermissionScope` to be scoped down to a specific protocol
- move getAuthor helper from `Record` util class to `Message` core class.

When DWAs request permissions, they will now be issued a `ProtocolsQuery` permission scoped to the protocol they are being authorized, as well as optionally a `ProtocolsConfigure` for that protocol.

Satisfies:
#801
#802
@LiranCohen
Copy link
Member Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LiranCohen