Protocol Interface Permissions #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 98.70% 98.71% +0.01%
==========================================
Files 73 74 +1
Lines 11335 11469 +134
Branches 1631 1652 +21
==========================================
+ Hits 11188 11322 +134
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
LiranCohen
commented
Sep 8, 2024
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
csuwildcat
previously approved these changes
Sep 8, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
thehenrytsai
reviewed
Sep 9, 2024
Co-authored-by: Henry Tsai <henrytsai@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtocolConfigureProtocolPermissionScopeto be scoped down to a specific protocolRecordutil class toMessagecore class.When DWAs request permissions, they will now be issued a
ProtocolsQuerypermission scoped to the protocol they are being authorized, as well as optionally aProtocolsConfigurefor that protocol.Satisfies:
#801
#802