Fold paymentInstructions inside payin and payout #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethan-tbd and
tomdaffurn
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
- Coverage 78.64% 76.88% -1.77%
==========================================
Files 30 32 +2
Lines 693 744 +51
Branches 65 71 +6
==========================================
+ Hits 545 572 +27
- Misses 114 132 +18
- Partials 34 40 +6
|
jiyoonie9
approved these changes
Jan 17, 2024
phoebe-lew
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses TBD54566975/tbdex#201
Update to
tbdexspec: TBD54566975/tbdex#223