Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pulling in PaymentDetails as an optional field inside QuoteDetails in Quote #201

Closed
jiyoonie9 opened this issue Dec 8, 2023 · 2 comments
Assignees
Milestone

Comments

@jiyoonie9
Copy link
Contributor

jiyoonie9 commented Dec 8, 2023

From @diehuxx 's comment on discord

Is there any strong reason Quote has a payin and payout field with QuoteDetails and it has PaymentInstructions with a its payin and payout field? Is there a reason we didn't want to fold PaymentInstruction as an optional field in QuoteDetails? No push back, it seems like a small thing to me, but curious if there's a use case that informed keeping the two properties separate.
https://github.com/TBD54566975/tbdex/tree/main/specs/protocol#quote

@diehuxx
Copy link

diehuxx commented Jan 15, 2024

Waiting until #206 is resolved to open PRs since this issue would create merge conflicts in the implementation changes. I have branches ready to PR as soon as #206 is done.

Spec change branch: https://github.com/TBD54566975/tbdex/compare/currency-199...quote-details-payment-instruction?expand=1
Javascript implementation change branch: https://github.com/TBD54566975/tbdex-js/compare/currency-199...quote-details?expand=1
Kotlin imeplementation change branch: https://github.com/TBD54566975/tbdex-kt/compare/currency-199...quote-details?expand=1

@diehuxx
Copy link

diehuxx commented Jan 17, 2024

Ready for review.

Spec: #223
Javascript: TBD54566975/tbdex-js#140
Kotlin: TBD54566975/tbdex-kt#136

@github-project-automation github-project-automation bot moved this from In Progress to Done in SDK Development Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants