kendall/main into main #97

KendallWeihe · 2024-04-19T13:09:05Z

This PR is a culmination of a few weeks of work. Ain't nobody gon' review this. If you want to track/review iteration, I suggest reviewing the Closed PRs because I've been intentional about breaking the changes up in smaller logical chunks.

Major changes include:

Change to CODEOWNERS (does anyone else want to be added?)
Hermit dependencies
Rust crates for:
- credentials
- crypto
- dids
- jwk
- jws
- jwt
- keys
Rust binding crates using WASM and UniFFI
Binded projects for TypeScript, Kotlin and Swift
Example applications for Kotlin and Swift

Closes #43
Closes #41
Closes #32
Closes #31
Closes #30
Closes #29
Closes #27
Closes #121
Closes #120

Opened many more tickets

…rs (#71)

… crypto to keys (#73)

…n source crate (#74)

…d KeyIdFragment.splice* functions, fix did:jwk creation (#83)

kirahsapong · 2024-04-22T21:03:30Z

I'll review-ish!

+1 me too but i will be slow

KendallWeihe · 2024-04-23T14:04:20Z

@nitro-neal @kirahsapong be forewarned, I'm merging this PR in but all it consist of is taking bindings/kt, bindings/swift, and bindings/ts and moving them into a binded/* directory. This should add clarity between the distinction of "bindings" (which are Rust projects which build the binded code) and "binded" (which are non-Rust projects which contain the binded code).

rs on  kendall/binded-directory-structure [$] via 🦀 1.77.2
➜ ls binded
kt	swift	ts

rs on  kendall/binded-directory-structure [$] via 🦀 1.77.2
➜ ls bindings
uniffi	wasm

Also, @nitro-neal @kirahsapong I have added you two to the CODEOWNERS. I'll try to stop merging changes in while this PR is under review.

Justfile

nitro-neal · 2024-04-23T17:23:46Z

binded/ts/pkg/web5_wasm_bg.wasm

By the way our wasm file is already 1.44 mb (and we just getting started) :)

I have a gut feeling we will ditch js bindings and keep our oldschool web5-js in this regard

I noticed that too, but not giving up yet!

Yeah like @nitro-neal said I would totally ditch it. The reality is that there is so much bespoke code in web5-js to support even the big and diverse JS runtimes such as server, browser, react native, electron that it's just not realistic at any future juncture to have Rust generate it all as WASM. In the future if we only have to support JS and Rust we'll be so far ahead of where we are today that at this point trying to hit the unrealistic goal of using WASM just doesn't seem like a great use of time.

Well said 👍

bindings/uniffi/build.rs

nitro-neal · 2024-04-23T17:44:30Z

crates/jws/src/lib.rs

+        let verification_method = bearer_did.document.get_verification_method(key_selector)?;
+        let kid = verification_method.id;
+        let alg = match verification_method.public_key_jwk.crv.as_str() {
+            "secp256k1" => "ES256K".to_string(),


n00b rust question, but is the to_string needed?

"this is a str which is an array of UTF-8 bytes" and "this is a String type which is managed on the heap".to_string()

basically it's a distinction between str and String types -- the former is a static memory (not sure if on the stack or in the static location in memory, but either way) and the latter is on the heap

there's a lot to even this question, just rust thangs

here's a good SO answer on this https://stackoverflow.com/a/24159933

nitro-neal · 2024-04-23T17:45:52Z

crates/jwt/src/lib.rs

+    use super::*;
+    use std::sync::Arc;
+
+    #[test]


is the end state to have tests in a different _test.rs file?

maybe, we can come to that if it we want I have no strong opinions, nor do I know what's idiomatic

examples/KotlinExample/dev.sh

examples/KotlinExample/run.sh

nitro-neal

Awesome job! Lots of good work

kirahsapong

nice work! i'm still going through and learning from this pr and will be long after its merged.

decentralgabe · 2024-04-23T20:30:12Z

crates/dids/src/method/spruce_mappers/document.rs

+                let spruce_jwk = ssi_vmm.get_jwk()?;
+                let alg = match spruce_jwk.algorithm {
+                    Some(Algorithm::ES256K) => "ES256K",
+                    Some(Algorithm::EdDSA) => "EdDSA",


should switch out EdDSA to Ed25519 here and elsewhere
https://www.ietf.org/archive/id/draft-ietf-jose-fully-specified-algorithms-02.html

Great callout. I did this but it'll be better to dedicate the time to do this right, so created a ticket and will follow up with it #128

decentralgabe · 2024-04-23T20:31:26Z

crates/jws/src/lib.rs

+        let kid = verification_method.id;
+        let alg = match verification_method.public_key_jwk.crv.as_str() {
+            "secp256k1" => "ES256K".to_string(),
+            "Ed25519" => "EdDSA".to_string(),


Suggested change

"Ed25519" => "EdDSA".to_string(),

"Ed25519" => "Ed25519".to_string(),

decentralgabe · 2024-04-23T20:32:02Z

crates/jwt/src/lib.rs

+        expiration: Option<i64>,
+        not_before: Option<i64>,
+        issued_at: Option<i64>,
+        jti: Option<String>,


prob fine to exclude for now but we will need x5c

yup! will come to when needed

KendallWeihe and others added 30 commits April 1, 2024 12:39

Add hermit, add rustup, add code workspace

4fefd91

Remove bindings code

3e9278e

Remove did:key

ea3c5a2

Add BearerDID, Identifier, web5-spec standardized types, Spruce mappe…

a7e763b

…rs (#71)

Replace ssi-jw* with josekit (#72)

e6c3e63

Fix merge conflict resolution bug

0cb7223

Add vc.rs, add bearer DID signing, add thread safety with Arc, rename…

fdb2a5f

… crypto to keys (#73)

Introduce jose crate which is a thin wrapper around the josekit ope…

1ee3082

…n source crate (#74)

Use jose crate in vc.rs (#75)

289a4aa

Fix clippy warnings, remove redundant code, fix KeyType to Curve

93c24fd

Name root in workspace and move it to top

d912ec3

Add jwt.sign functionality w/ native bearer DID support (#76)

d8f39ed

Don't allow private keys to leave the KeyStore (#77)

96a7d61

Add JWT and JWS signing, decoding and verification (#78)

87e5a4c

Remove josekit for binding compatibility (#80)

c0ee629

Rename vc func to sign_vcjwt (#81)

ce9588c

Add import & export key functionality

e007857

Add from_key_manager function

0352b73

Fix crypto dependencies

f4a1e6b

Add wasm bindings for jwk, crypto and keys (#82)

70791d0

Add from_vcjwt function, rename DataModel to VerifiableCredential, ad…

b8dfad2

…d KeyIdFragment.splice* functions, fix did:jwk creation (#83)

Add key alias override, fix did:jwk map bug, fix jws verify bug (#84)

3677552

Commit wasm pkg/ dir, fix wasm build (#85)

f5e83a0

Remove async-trait in favor of impl Future (#86)

43daa0f

Add dids/identifier bindings (#87)

a35dbd6

Use js-sys Object+Reflect instead of crazy Function call to JSON.parse()

f075f61

Add js_rename to favor snakeCase in js

6b8971b

Add UniFFI scaffolding with basic jwk::Jwk binding (#88)

ac83aae

Fix typo in thumbprint, remove unused error case

204aa44

Add complete UniFFI bindings for jwk crate (#89)

5933ade

KendallWeihe and others added 2 commits April 23, 2024 10:03

Introduce binded/ directory & add kt, swift, and ts packages (#124)

a25223e

Add @nitro-neal @kirahsapong to CODEOWNERS

87c8dd6

KendallWeihe requested review from nitro-neal and kirahsapong April 23, 2024 17:01

Add @shamilovtim @diehuxx to CODEOWNERS

dfbfc40

nitro-neal reviewed Apr 23, 2024

View reviewed changes

Justfile Outdated Show resolved Hide resolved

nitro-neal reviewed Apr 23, 2024

View reviewed changes

bindings/uniffi/build.rs Show resolved Hide resolved

nitro-neal reviewed Apr 23, 2024

View reviewed changes

examples/KotlinExample/dev.sh Outdated Show resolved Hide resolved

nitro-neal reviewed Apr 23, 2024

View reviewed changes

examples/KotlinExample/run.sh Outdated Show resolved Hide resolved

nitro-neal approved these changes Apr 23, 2024

View reviewed changes

kirahsapong approved these changes Apr 23, 2024

View reviewed changes

decentralgabe reviewed Apr 23, 2024

View reviewed changes

KendallWeihe and others added 4 commits April 23, 2024 16:33

Add @decentralgabe to CODEOWNERS

68f12c7

Fix Kotlin libweb5.dylib loading (#126)

3ac58f6

Add useful comment to uniffi build script

4eaaec4

Add Justfile in example projects instead of scripts

64a4922

KendallWeihe mentioned this pull request Apr 24, 2024

Fully specify Ed25519 in JOSE features #128

Open

Rename just test-bindings to test-binded for consistency

3432246

KendallWeihe merged commit b7ac054 into main Apr 24, 2024
9 checks passed

KendallWeihe deleted the kendall/main branch April 24, 2024 13:21

KendallWeihe restored the kendall/main branch April 24, 2024 21:41

KendallWeihe deleted the kendall/main branch April 24, 2024 21:46

KendallWeihe mentioned this pull request May 3, 2024

Correct typo 'Ed25199' should be 'Ed25519' #152

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kendall/main into main #97

kendall/main into main #97

KendallWeihe commented Apr 19, 2024 •

edited

Loading

kirahsapong commented Apr 22, 2024

KendallWeihe commented Apr 23, 2024

nitro-neal Apr 23, 2024

KendallWeihe Apr 23, 2024

shamilovtim Apr 24, 2024

KendallWeihe Apr 24, 2024

nitro-neal Apr 23, 2024

KendallWeihe Apr 24, 2024

nitro-neal Apr 23, 2024

KendallWeihe Apr 24, 2024

nitro-neal left a comment

kirahsapong left a comment

decentralgabe Apr 23, 2024

KendallWeihe Apr 24, 2024

decentralgabe Apr 23, 2024

decentralgabe Apr 23, 2024

KendallWeihe Apr 24, 2024

	"Ed25519" => "EdDSA".to_string(),
	"Ed25519" => "Ed25519".to_string(),

kendall/main into main #97

kendall/main into main #97

Conversation

KendallWeihe commented Apr 19, 2024 • edited Loading

kirahsapong commented Apr 22, 2024

KendallWeihe commented Apr 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nitro-neal left a comment

Choose a reason for hiding this comment

kirahsapong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KendallWeihe commented Apr 19, 2024 •

edited

Loading