AppVeyor: Run all the lint routines #8177 #8193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkurniawan07
requested changes
Dec 4, 2017
| @@ -107,6 +107,7 @@ Make the changes to the code, tests, and documentations as needed by the issue. | |||
|
|
|||
| ```sh | |||
| ./gradlew lint | |||
| npm run lint | |||
| @@ -37,5 +37,6 @@ build_script: | |||
|
|
|||
| test_script: | |||
| - npm run build | |||
| - npm run lint | |||
There was a problem hiding this comment.
- The lint routine should be on the
build scriptpart. - Need to lint the Java files also with the appropriate command.
You can take a look at the Travis build file for some inspiration.
|
Hi @baczus0, any updates here? |
|
Closing due to inactivity. @baczus0 feel free to request for reopen when you're ready to resume the work done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8177