Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppVeyor: Run all the lint routines #8177 #8193

Closed
wants to merge 2 commits into from
Closed

AppVeyor: Run all the lint routines #8177 #8193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3efad
added npm run lint to appveyor config
Dec 4, 2017
773d017
added npm run lint to appveyor config
Dec 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,6 @@ build_script:

test_script:
- npm run build
- npm run lint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The lint routine should be on the build script part.
  • Need to lint the Java files also with the appropriate command.

You can take a look at the Travis build file for some inspiration.

- gradlew.bat appengineStart
- gradlew.bat ciTests
1 change: 1 addition & 0 deletions docs/process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ Make the changes to the code, tests, and documentations as needed by the issue.

```sh
./gradlew lint
npm run lint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

```
* **Dev green**, i.e. all *local tests* are passing on your dev server.<br>
You are more than welcome to also ensure all *CI tests* are passing on your dev server.
Expand Down