Normalizing Japanese punctuation per issue #2337. #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydb
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
According to Wikipedia the IDEOGRAPHIC COMMA (U+3001) is used in Japanese where we use COMMA (U+002C) as a separator of items in a list. All of these appear to be that kind of case.
Furthermore, in all 5 cases of //*[@xml:lang eq 'ja'][contains( ., ',')] the U+002C does not seem to be a list item separator.
(That said, I think an xml:lang="en" should be added to #MEASUREMENT-egXML-cw. This need not be part of this PR, of course.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure who to choose to review this -- I don't see any native Japanese speakers in the list of people -- but it's very basic stuff and I can explain it to anyone.