🔀 Merge pull request #489

🚧 add failsafe on updateOldPrices method - @idinium96
TF2Autobot · Mar 25, 2021 · 0dbecdf · 0dbecdf
2 parents 0a7eca9 + 915c3e8
commit 0dbecdf
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 3 deletions.
diff --git a/src/classes/MyHandler/MyHandler.ts b/src/classes/MyHandler/MyHandler.ts
@@ -294,6 +294,30 @@ export default class MyHandler extends Handler {
         this.refreshTimeout = setTimeout(() => {
             this.enableAutoRefreshListings();
         }, 5 * 60 * 1000);
+
+        // Send notification to admin/Discord Webhook if there's any item failed to go through updateOldPrices
+        const failedToUpdateOldPrices = this.bot.pricelist.failedUpdateOldPrices;
+
+        if (failedToUpdateOldPrices.length > 0) {
+            const dw = this.opt.discordWebhook.sendAlert;
+            const isDwEnabled = dw.enable && dw.url !== '';
+
+            if (this.opt.sendAlert.enable && this.opt.sendAlert.failedToUpdateOldPrices) {
+                if (isDwEnabled) {
+                    sendAlert('failedToUpdateOldPrices', this.bot, '', null, null, failedToUpdateOldPrices);
+                } else {
+                    this.bot.messageAdmins(
+                        `Failed to update old prices (probably because autoprice is set to true but item does not exist` +
+                            ` on the pricer source):\n\n${failedToUpdateOldPrices.join(
+                                '\n'
+                            )}\n\nAll items above has been temporarily disabled.`,
+                        []
+                    );
+                }
+            }
+
+            this.bot.pricelist.resetFailedUpdateOldPrices = 0;
+        }
     }
 
     onShutdown(): Promise<void> {

diff --git a/src/classes/Options.ts b/src/classes/Options.ts
@@ -67,7 +67,8 @@ export const DEFAULTS = {
             onSuccessUpdatePartialPriced: true,
             onFailedUpdatePartialPriced: true
         },
-        receivedUnusualNotInPricelist: true
+        receivedUnusualNotInPricelist: true,
+        failedToUpdateOldPrices: true
     },
 
     pricelist: {
@@ -1034,6 +1035,7 @@ interface SendAlert extends OnlyEnable {
     unableToProcessOffer?: boolean;
     partialPrice?: PartialPrice;
     receivedUnusualNotInPricelist?: boolean;
+    failedToUpdateOldPrices?: boolean;
 }
 
 interface PartialPrice {

diff --git a/src/classes/Pricelist.ts b/src/classes/Pricelist.ts
@@ -176,6 +176,12 @@ export default class Pricelist extends EventEmitter {
 
     private retryGetKeyPrices: NodeJS.Timeout;
 
+    failedUpdateOldPrices: string[] = [];
+
+    set resetFailedUpdateOldPrices(value: number) {
+        this.failedUpdateOldPrices.length = value;
+    }
+
     constructor(
         private readonly priceSource: Pricer,
         private readonly schema: SchemaManager.Schema,
@@ -767,7 +773,21 @@ export default class Pricelist extends EventEmitter {
                 const item = SKU.fromString(sku);
 
                 // Go through pricestf/custom pricer prices
-                const grouped = groupedPrices[item.quality][item.killstreak];
+                let grouped: Item[];
+                try {
+                    grouped = groupedPrices[item.quality][item.killstreak];
+                } catch (err) {
+                    if (currPrice.group !== 'failed-updateOldPrices') {
+                        currPrice.enabled = false;
+                        currPrice.group = 'failed-updateOldPrices';
+                        this.failedUpdateOldPrices.push(sku);
+                        log.warn(`updateOldPrices failed for ${sku}`, err);
+                        pricesChanged = true;
+                    }
+
+                    continue;
+                }
+
                 const groupedCount = grouped.length;
 
                 for (let j = 0; j < groupedCount; j++) {

diff --git a/src/lib/DiscordWebhook/sendAlert.ts b/src/lib/DiscordWebhook/sendAlert.ts
@@ -37,7 +37,8 @@ type AlertType =
     | 'autoUpdatePartialPriceSuccess'
     | 'autoUpdatePartialPriceFailed'
     | 'isPartialPriced'
-    | 'unusualInvalidItems';
+    | 'unusualInvalidItems'
+    | 'failedToUpdateOldPrices';
 
 export default function sendAlert(
     type: AlertType,
@@ -192,6 +193,12 @@ export default function sendAlert(
         title = 'Partial price update';
         description = msg;
         color = '16776960'; // yellow
+    } else if (type === 'failedToUpdateOldPrices') {
+        title = 'Failed to update old prices';
+        description =
+            `Failed to update old prices (probably because autoprice is set to true but item does not exist` +
+            ` on the pricer source):\n\n${items.join('\n')}\n\nAll items above has been temporarily disabled.`;
+        color = '16711680'; // red
     } else {
         title = 'High Valued Items';
         description = `Someone is trying to take your **${items.join(', ')}** that is not in your pricelist.`;

diff --git a/src/schemas/options-json/options.ts b/src/schemas/options-json/options.ts
@@ -485,6 +485,9 @@ export const optionsSchema: jsonschema.Schema = {
                 },
                 receivedUnusualNotInPricelist: {
                     type: 'boolean'
+                },
+                failedToUpdateOldPrices: {
+                    type: 'boolean'
                 }
             },
             required: [