🚧 add failsafe on updateOldPrices method #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
idinium96
added a commit
that referenced
this pull request
Mar 25, 2021
#498 ## Changes - 🚧 add failsafe on updateOldPrices method (#489) - new options.json property: `sendAlert.failedToUpdateOldPrices` (default is `true`) - 🔄 update core dependencies: - `tf2-schema-2`: 🧪 add support for Chemistry Set (`!sku` command) (#490) - `bptf-listings-2`: 🔨 fix defindex for Exclusive Genuine items (#496) - 🎭 `!getSlots` or `!listings` command (#499) - 🔎 execute pricecheck on add, update, and remove commands (#500) - 🔨 add missing `resetgroup` in `!update all=true` (#501) ## Fixes - PPU: - 🔨 fix the unintended rare occurrence (#497) - 🔨 fix info on auto-update partially priced item and update Discord Webhook embed color (#491) - 🐛 fix manual pricing update reverted to autoprice - closes #488 (#492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for custom pricer user, but can also occur if you manually change the
autopriceproperty of any item that does not exist in the pricer pricelist, i.e. most skins or some unusual that does not exist in the source pricelist should be manually priced, and then if you edit yourpricelist.jsonand change theautopricetotrue(or even if you use!update all=true&autoprice=truecommand), an error will occur here:tf2autobot/src/classes/Pricelist.ts
Line 770 in 43ba1e5
and then your bot will use the temporary "hard-coded" key prices:
tf2autobot/src/classes/Pricelist.ts
Lines 643 to 648 in 43ba1e5
These changes will skip the affected item and temporarily disabled it.
Discovered by @Bonfire
EDIT:
Apparently, this will only occur on a custom autopricer.