Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot reverting to autopricing for selling and item when buy.keys is not set in !update command #488

Closed
SachinVenugopalan30 opened this issue Mar 22, 2021 · 1 comment · Fixed by #492 or #498
Closed

Bot reverting to autopricing for selling and item when buy.keys is not set in !update command #488

SachinVenugopalan30 opened this issue Mar 22, 2021 · 1 comment · Fixed by #492 or #498
Labels
bug Something isn't working

Comments

@SachinVenugopalan30
Copy link
Collaborator

Describe the bug
Any high value item that is according to the owner's settings will be disabled. If the user wishes to set a manual price but does not set buy.keys while running the !update sku=<>&enabled=true command, the bot will revert to autopricing after a while instead of using the sell.keys or sell.metal that was manually set by the owner.

To Reproduce

Steps to reproduce the behavior:

  1. Receive a high-value item from a trade(say an item with high value parts/paint/killstreaker/spell)
  2. Send the !update command as mentioned earlier but DO NOT add the buy.keys/buy.metal part. So your update command will look something like !update sku=30998;6&enabled=true&sell.keys=25
  3. Wait. Unsure of when exactly will the bot revert to autopricing.

Expected behavior
Bot should maintain the manual price until the item has sold.

Screenshots and logs
Receiving and setting the item to sell at a price set by the owner:
image

image

image

As you can see from the image above, in the _ITEM_PRICES segment, even though I set sell.keys to 2, the bot reverted to 1 key, but pricing method is still 'manual'. Time span between setting the price and the bot selling the item for that price was a little above 24 hours, although this depends on the item being sold.

Meanwhile, if you have set buy.keys in the same update message, the bot will not revert to autopricing.
image

image

When I sent !update sku=30599;6&sell.keys=2&buy.metal=1, the bot did not revert to autopricing.

image

Version: v3.6.5.
@SachinVenugopalan30 SachinVenugopalan30 added the bug Something isn't working label Mar 22, 2021
@idinium96
Copy link
Member

Thanks for the report.

@idinium96 idinium96 mentioned this issue Mar 23, 2021
Merged
@idinium96 idinium96 linked a pull request Mar 23, 2021 that will close this issue
🐛 fix manual pricing reverted to autoprice #492
Merged
@idinium96 idinium96 mentioned this issue Mar 25, 2021
Merged
@idinium96 idinium96 linked a pull request Mar 25, 2021 that will close this issue
prepare v3.7.1 #498
Merged
idinium96 added a commit that referenced this issue Mar 25, 2021
@idinium96
🔀 Merge pull request #498
5d615f9 
#498

## Changes
- 🚧 add failsafe on updateOldPrices method (#489)
    - new options.json property: `sendAlert.failedToUpdateOldPrices` (default is `true`)
- 🔄 update core dependencies:
    - `tf2-schema-2`: 🧪 add support for Chemistry Set (`!sku` command) (#490)
    - `bptf-listings-2`: 🔨 fix defindex for Exclusive Genuine items (#496)
- 🎭 `!getSlots` or `!listings` command (#499)
- 🔎 execute pricecheck on add, update, and remove commands (#500)
- 🔨 add missing `resetgroup` in `!update all=true` (#501)

## Fixes
- PPU: 
    - 🔨 fix the unintended rare occurrence (#497)
    - 🔨 fix info on auto-update partially priced item and update Discord Webhook embed color (#491)
- 🐛 fix manual pricing update reverted to autoprice - closes #488 (#492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@SachinVenugopalan30 @idinium96