Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 fix bot crash if enableSocket set to false #543

Merged
merged 1 commit into from
Apr 3, 2021
Merged

🔨 fix bot crash if enableSocket set to false #543

merged 1 commit into from
Apr 3, 2021

Conversation

idinium96
Copy link
Member

@idinium96 idinium96 commented Apr 3, 2021 •
edited
Loading

image

@idinium96 idinium96 merged commit 200a879 into development Apr 3, 2021
@idinium96 idinium96 deleted the fix-crash branch April 3, 2021 02:45
@idinium96 idinium96 mentioned this pull request Apr 4, 2021
Merged
idinium96 added a commit that referenced this pull request Apr 6, 2021
@idinium96
🔀 Merge pull request #548
0dfb1dd 
#548

## Improvements/Major Changes
- 🩹 improvement on PPU - closes issue #506 (read #520)
    - once updated to v3.8.0, your pricelist.json is no longer usable on the lower versions.
    - only effective on newly bought items.

## Added
- ✨ an option to show detailed time taken (#549)
    - new options: `tradeSummary.showDetailedTimeTaken` (default is `true`).

## Changed
- 🔨 include the old group name in high-value disabled item notification (#544)

## Fixes
- 🔨 fixed bot crash if enableSocket set to false (#543)
- 🐛 possible fix negative profit when accepting invalid items (#545, a344d0d)
- 🔨 fixed catch the wrong error while updating `oldPrices` (mostly if use custom pricer) (#547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@idinium96