🐛 possible fix negative profit when accepting invalid items #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
idinium96
commented
Apr 3, 2021
idinium96
commented
- Only if that particular item is priced. If no price found with the pricer, then it will still show a negative profit.
Merged
idinium96
added a commit
that referenced
this pull request
Apr 6, 2021
#548 ## Improvements/Major Changes - 🩹 improvement on PPU - closes issue #506 (read #520) - once updated to v3.8.0, your pricelist.json is no longer usable on the lower versions. - only effective on newly bought items. ## Added - ✨ an option to show detailed time taken (#549) - new options: `tradeSummary.showDetailedTimeTaken` (default is `true`). ## Changed - 🔨 include the old group name in high-value disabled item notification (#544) ## Fixes - 🔨 fixed bot crash if enableSocket set to false (#543) - 🐛 possible fix negative profit when accepting invalid items (#545, a344d0d) - 🔨 fixed catch the wrong error while updating `oldPrices` (mostly if use custom pricer) (#547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.