CTFNote v3 #237
Merged
CTFNote v3 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fixes for tags
Now it correctly scales for both desktop and mobile.
The table is difficult to see on mobile but very useful on desktop, so we change the default values depending on the platform.
Task list improvements on mobile devices
The actual .env should not be part of the repository to prevent any secrets to be stored in git.
Remove dotenv file from git
Improve mention resolution
Pinning to the channel is not silent and we don't want that. So instead we now save the task link in the topic using the delimiter /-/
Change pin behavior and resolve channel names in archive
It is mandatory to create an archive first before deleting the CTF. This prevents data loss and the resulting task can always be deleted manually. The archive command will now not delete the channels anymore. Finishing of the commands will now be reflected in the bot reply.
Add `/delete` to delete Discord CTF integration
Now they will be properly rendered by Hedgedoc
When the note content is too big, it will be split in multiple pads. But these pads won't be visible in the export. This is now fixed by recursively fetch all tasks by matching the pad url.
Discord archive: image handling and recursive pad export
Otherwise this will result in errors.
Subtask export: cyclic references and uploads exclusion
In the end, it was not used but still a good feature to have for this component.
Now all the capabilities and limitations of the bot are documented in the README.
Discord: privilege change sync and better documentation
Remove GHCR authentication notice in README
Update Hedgedoc to 1.9.9
Parsing challenges from https://angstromctf.com/
This corresponds to the outer-nginx and may also need to be set before the change will actually be effective.
With this it will apply to all requests done, so also the /uploads endpoint and not only the endpoint for Hedgedoc.
Increase Nginx upload size limit
… into solve-task-shortcut
When a sync has been performed, the old implementation causes a release of the database PoolClient, causing any future database operation to fail. This is due to the event sync code being triggered from the context of GraphQL queries instead of a separate context when an incoming event from Discord is processed. The code has now been rewritten to take the context.pgClient database client which is the current GraphQL pgClient. This client is used in all database operations and not released so it can be used in the future. This will stop the hanging of the server when a Discord event link sync is done. This issue was only reliable reproducible with quite some members interested in an event. I tested this with 13 people interested. In the future we should rewrite this code to always take a pgClient in the database code and create a new pgClient at a higher level when not available and otherwise always use the context.pgClient. At lower levels we should not be caring about releasing or not because this can only cause issues.
Fix Discord event link hanging issue
Added ctrl + s shortcut to submit flag on task pages
This is useful for testing if a branch builds.
This was referenced Apr 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Please note that when pulling from an old version, you may be forced to revert/remove the
.envfile. Backup your secrets before doing so to save yourself some time.What is new
What is fixed