Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hardcoded labels to xlf files for translation #545

Closed
tmotyl opened this issue Jan 31, 2023 · 2 comments · Fixed by #601
Closed

Move hardcoded labels to xlf files for translation #545

tmotyl opened this issue Jan 31, 2023 · 2 comments · Fixed by #601
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tmotyl
Copy link
Collaborator

tmotyl commented Jan 31, 2023

In order to be able to translate extension labels in Crowdin,the language xlf file needs to be created and hardcoded labels needs to be moved there (e.g. for site configuration).
@tmotyl tmotyl added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 31, 2023
@canpse
Copy link

canpse commented Jan 31, 2023 •
edited
Loading

Hello, I don't know Crowdin but if you help me find the hardcoded labels I am sure I can help making the xlf file.

@tmotyl
Copy link
Collaborator Author

tmotyl commented Feb 2, 2023

thanks @canpse.
you can see some here: https://github.com/TYPO3-Headless/headless/blob/master/Configuration/SiteConfiguration/Overrides/site.php
and
https://github.com/TYPO3-Headless/headless/blob/master/Configuration/SiteConfiguration/Overrides/site_base_variant.php

@lukas-maxheim lukas-maxheim mentioned this issue May 25, 2023
Merged
lukaszuznanski pushed a commit that referenced this issue Jun 2, 2023
@lukas-maxheim
[FEATURE] Move hardcoded labels to xlf files to support translation v…
b1d4b0b 
…ia crowdin (#545) (#601)

* [TASK] Add xlf file for translating the site configuration

Related: #545

* [TASK] Replace hardcoded labels with the labels from translation file

Related: #545

* [TASK] Update indentation for GalleryProcessor.php

- Update indentation for GalleryProcessor.php to pass the code-analysis of php-cs-fixer

Related: #545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Move hardcoded labels to xlf files to support translation via crowdin (#545)
2 participants
@tmotyl @canpse