Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move hardcoded labels to xlf files to support translation via crowdin (#545) #601

Merged
merged 3 commits into from
Jun 2, 2023
Merged

[FEATURE] Move hardcoded labels to xlf files to support translation via crowdin (#545) #601

merged 3 commits into from
Jun 2, 2023

Conversation

lukas-maxheim
Copy link
Contributor

This changes moves the hardcoded labels into a xlf file (in this case for labels inside "./Configuration/SiteConfiguration/"):

  • Add xlf file for translating the site configuration
  • Replace hardcoded labels with the labels from the translation file

Related: #545
Resolves: #545

@coveralls
Copy link

coveralls commented May 25, 2023

Pull Request Test Coverage Report for Build 5081876029

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.019%

Totals Coverage Status
Change from base Build 4959189590: 0.0%
Covered Lines: 774
Relevant Lines: 1248

💛 - Coveralls

- Update indentation for GalleryProcessor.php to pass the code-analysis of php-cs-fixer

Related: #545
@lukaszuznanski lukaszuznanski merged commit b1d4b0b into TYPO3-Headless:master Jun 2, 2023
@lukas-maxheim lukas-maxheim deleted the feature/545-move-hardcoded-labels-to-xlf-files-for-translation branch June 13, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move hardcoded labels to xlf files for translation
4 participants