Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adding ide info to /completion route #2766

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

Sma1lboy
Copy link
Collaborator

@Sma1lboy Sma1lboy commented Aug 1, 2024

This PR addresses part of the issue mentioned in #2581 by implementing server-side changes to extract and process IDE information from the User-Agent header.

Description:

  • Server Getting Ide info from header's user-agent
  • save ide info as json string

Example format of ide info:

{
    "name": "Visual Studio Code",
    "version": "1.91.1",
    "extensionName": "Tabby",
    "extensionPublisher": "TabbyML",
    "extensionVersion": "1.8.0-dev",
    "osType": "Darwin",
    "osRelease": "23.5.0",
    "platform": "darwin",
    "arch": "arm64"
}

@wsxiaoys
Copy link
Member

wsxiaoys commented Aug 1, 2024

cc @xxs-wallace

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend extract backend change (rust change) into a separate PR for review.

crates/tabby-common/src/api/event.rs Outdated Show resolved Hide resolved
@Sma1lboy Sma1lboy force-pushed the feat-adding-ide-info branch from 0c85397 to d908978 Compare August 3, 2024 09:56
@Sma1lboy Sma1lboy changed the title feat: adding ide info to server and clients feat: adding ide info to server routes Aug 3, 2024
@Sma1lboy Sma1lboy marked this pull request as ready for review August 3, 2024 11:10
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@wsxiaoys wsxiaoys enabled auto-merge (squash) August 5, 2024 00:17
@wsxiaoys wsxiaoys changed the title feat: adding ide info to server routes feat(core): adding ide info to server routes Aug 5, 2024
@wsxiaoys wsxiaoys changed the title feat(core): adding ide info to server routes feat(core): adding ide info to /completion routes Aug 5, 2024
@wsxiaoys wsxiaoys changed the title feat(core): adding ide info to /completion routes feat(core): adding ide info to /completion route Aug 5, 2024
@wsxiaoys wsxiaoys disabled auto-merge August 5, 2024 00:51
@wsxiaoys wsxiaoys merged commit e76ac76 into TabbyML:main Aug 5, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants