-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add general IDE info to User-Agent for Tabby clients #2781
Conversation
Should I do another PR for intellij? or I can put them together This PR is waiting for #2766 |
@Sma1lboy Thanks for your PR!
@wsxiaoys for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the implementation:
- We can get the ide info at LSP initialization, so it is not required to pass it in each completion call. Please refer to protocol definition and implementation passing params to TabbyAgent class. It's not required to modify code in vscode/intellij plugin, all stuff will be done in tabby-agent.
- Let's set the header user-agent at http client level.
Sure, I'll take a look tonight |
8c15f1d
to
73e51d0
Compare
@icycodes Thanks for your suggestions. I've realized that most of my previous code was focused on creating a parameter for ideInfo that could be transmitted by the client. It wasn't until I read the section of the code about lifecycle that I discovered this process had already been written there. :( |
Simply import the "package.json" should be ok. Here is an example. |
This addresses the remaining part of the issue mentioned in #2581.
Example User-Agent format: