Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with c++17 trigger error C2872: 'byte': ambiguous symbol #698

Closed
wolfviking0 opened this issue May 13, 2019 · 2 comments
Closed

Build with c++17 trigger error C2872: 'byte': ambiguous symbol #698

wolfviking0 opened this issue May 13, 2019 · 2 comments

Comments

@wolfviking0
Copy link

Describe the bug
Build openface with c++17 give an issue on my windows because std now have std::byte
https://developercommunity.visualstudio.com/content/problem/93889/error-c2872-byte-ambiguous-symbol.html

To Reproduce
Enable the CXX_STANDARD 17 trigger the issue

Desktop (please complete the following information):

  • OS: Windows
  • Version 10
  • Compiler MSVC
@TadasBaltrusaitis
Copy link
Owner

This is a clash between byte definition in dlib and in std, I'm fixing this issue and moving the entire codebase to C++17, the new version will have it fixed.

@TadasBaltrusaitis TadasBaltrusaitis mentioned this issue Jul 13, 2019
Merged
TadasBaltrusaitis added a commit that referenced this issue Jul 13, 2019
@TadasBaltrusaitis
Updating OpenFace to version 2.2.0 (#741)
e4a57e1 
Change log:

Moving to C++17. This means that the code can only be build using C++17 compilers (e.g. g++ >8 and Visual Studio 2017, clang > 5), fixing related bugs - (#698, #629, #641)
Removing an explicit dependency on boost (all the filesystem operations are performed using std::filesystem or boost::filesysteme). If boost is available it will used boost:filesystem, otherwise std::filesystem (this requires C++17)
Visual Studio 2017 is now the main version for Visual Studio builds, VS 2015 is no longer supported
Updating OpenCV to 4.1 version (#511)
Fixing a bug with output images when using GUI (#694)
Updating RAWImage - #609, so it can be initialized from System.Drawing.Bitmap directly
Fixing overlap detection for multi face tracking (#693)
@TadasBaltrusaitis
Copy link
Owner

Should be fixed in the new version.

ratgen pushed a commit to ratgen/OpenFace that referenced this issue Jul 7, 2022
@TadasBaltrusaitis
Updating OpenFace to version 2.2.0 (TadasBaltrusaitis#741)
b330656 
Change log:

Moving to C++17. This means that the code can only be build using C++17 compilers (e.g. g++ >8 and Visual Studio 2017, clang > 5), fixing related bugs - (TadasBaltrusaitis#698, TadasBaltrusaitis#629, TadasBaltrusaitis#641)
Removing an explicit dependency on boost (all the filesystem operations are performed using std::filesystem or boost::filesysteme). If boost is available it will used boost:filesystem, otherwise std::filesystem (this requires C++17)
Visual Studio 2017 is now the main version for Visual Studio builds, VS 2015 is no longer supported
Updating OpenCV to 4.1 version (TadasBaltrusaitis#511)
Fixing a bug with output images when using GUI (TadasBaltrusaitis#694)
Updating RAWImage - TadasBaltrusaitis#609, so it can be initialized from System.Drawing.Bitmap directly
Fixing overlap detection for multi face tracking (TadasBaltrusaitis#693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfviking0 @TadasBaltrusaitis